diff options
| author | Morten Rasmussen <morten.rasmussen@arm.com> | 2015-02-03 13:54:11 +0000 |
|---|---|---|
| committer | Juri Lelli <juri.lelli@arm.com> | 2015-03-03 16:43:00 +0000 |
| commit | 0b625debbaa29bf992fe9d181127e114244eebac (patch) | |
| tree | 2e5874aa144fe4f092ebfccd2e4899e518b4c7ec | |
| parent | c0949c8ec7a2f0ef288641b4cf3acd96563237f7 (diff) | |
sched: Disable energy-unfriendly nohz kicksstable/sched-core
With energy-aware scheduling enabled nohz_kick_needed() generates many
nohz idle-balance kicks which lead to nothing when multiple tasks get
packed on a single cpu to save energy. This causes unnecessary wake-ups
and hence wastes energy. Make these conditions depend on !energy_aware()
for now until the energy-aware nohz story gets sorted out.
cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
| -rw-r--r-- | kernel/sched/fair.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 3a8a8acc3b8..9823e39f164 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7735,6 +7735,8 @@ end: clear_bit(NOHZ_BALANCE_KICK, nohz_flags(this_cpu)); } +static int cpu_overutilized(int cpu, struct sched_domain *sd); + /* * Current heuristic for kicking the idle load balancer in the presence * of an idle cpu in the system. @@ -7774,12 +7776,13 @@ static inline bool nohz_kick_needed(struct rq *rq) if (time_before(now, nohz.next_balance)) return false; - if (rq->nr_running >= 2) + sd = rcu_dereference(rq->sd); + if (rq->nr_running >= 2 && (!energy_aware() || cpu_overutilized(cpu, sd))) return true; rcu_read_lock(); sd = rcu_dereference(per_cpu(sd_busy, cpu)); - if (sd) { + if (sd && !energy_aware()) { sgc = sd->groups->sgc; nr_busy = atomic_read(&sgc->nr_busy_cpus); |