diff options
author | Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> | 2009-07-03 08:30:10 -0500 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2009-07-29 23:30:40 +0200 |
commit | b6ecb93388d2dea47182a7afe3a4f4de80a6d0e6 (patch) | |
tree | 80c9527c140b27f658b0267e9de039959c23266e | |
parent | 0f2c3c2b4cbac06fa3080bc350b0defb9d0f525e (diff) |
net: NOHZ: local_softirq_pending with tickless
On one of my machines with tickless kernel and plip I get messages :
NOHZ: local_softirq_pending 08
always when using plip (on other machine with tickless kernel and plip I
get no errors). Thebug happens both on 2.6.21 and 2.6.22-rc1
This patch fixes that. Note that plip calls netif_rx neither from hardware
interrupt nor from ksoftirqd, so there is no one who would wake
ksoftirqd then. netif_tx calls only
__raise_softirq_irqoff(NET_RX_SOFTIRQ), which sets softirq bit, but
doesn't wake ksoftirqd.
[ tglx: Removed the remaining users of __raise_softirq_irqoff() as well. ]
Signed-off-by: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 64bf5411abcb..e9b06a7b8800 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2879,7 +2879,7 @@ out: softnet_break: __get_cpu_var(netdev_rx_stat).time_squeeze++; - __raise_softirq_irqoff(NET_RX_SOFTIRQ); + raise_softirq_irqoff(NET_RX_SOFTIRQ); goto out; } |