diff options
| author | David Howells <dhowells@redhat.com> | 2005-08-03 13:19:03 +0100 |
|---|---|---|
| committer | Chris Wright <chrisw@osdl.org> | 2005-08-14 17:20:10 -0700 |
| commit | 1cc2029def8e8b279c050b517a3d635b8a8ad351 (patch) | |
| tree | f62b6a4ed97f3f9f9fb7085ed3c1651dedaffea4 | |
| parent | 49f8907fb9de31d3a0a099fef0f42ccdcdc9c7e7 (diff) | |
[PATCH] CAN-2005-2098 Error during attempt to join key management session can leave semaphore pinned
The attached patch prevents an error during the key session joining operation
from hanging future joins in the D state [CAN-2005-2098].
The problem is that the error handling path for the KEYCTL_JOIN_SESSION_KEYRING
operation has one error path that doesn't release the session management
semaphore. Further attempts to get the semaphore will then sleep for ever in
the D state.
This can happen in four situations, all involving an attempt to allocate a new
session keyring:
(1) ENOMEM.
(2) The users key quota being reached.
(3) A keyring name that is an empty string.
(4) A keyring name that is too long.
Any user may attempt this operation, and so any user can cause the problem to
occur.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | security/keys/process_keys.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index 2eb0e471cd40..54622585c2c5 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c @@ -641,7 +641,7 @@ long join_session_keyring(const char *name) keyring = keyring_alloc(name, tsk->uid, tsk->gid, 0, NULL); if (IS_ERR(keyring)) { ret = PTR_ERR(keyring); - goto error; + goto error2; } } else if (IS_ERR(keyring)) { |