diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2005-08-03 18:43:22 -0700 |
|---|---|---|
| committer | Chris Wright <chrisw@osdl.org> | 2005-08-14 17:20:07 -0700 |
| commit | 9becc8e36ec9561fde0fbc17d09d707e36277d0a (patch) | |
| tree | 666c3df4f047fa10c228bb04921f3a0033a11292 | |
| parent | b8f212953417021b3b92a250babacca6dd7784ea (diff) | |
[PATCH] sys_set_mempolicy() doesnt check if mode < 0
A kernel BUG() is triggered by a call to set_mempolicy() with a negative
first argument. This is because the mode is declared as an int, and the
validity check doesnt check < 0 values. Alternatively, mode could be
declared as unsigned int or unsigned long.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | mm/mempolicy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 08c41da429cf..b8e1ba10a8e5 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -409,7 +409,7 @@ asmlinkage long sys_set_mempolicy(int mode, unsigned long __user *nmask, struct mempolicy *new; DECLARE_BITMAP(nodes, MAX_NUMNODES); - if (mode > MPOL_MAX) + if (mode < 0 || mode > MPOL_MAX) return -EINVAL; err = get_nodes(nodes, nmask, maxnode, mode); if (err) |