aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2010-05-26 16:48:23 +0200
committerThomas Gleixner <tglx@linutronix.de>2010-05-26 16:51:21 +0200
commitea17fed8d36978aa00f844949a1d820dfe58b992 (patch)
tree997587c3e7850970e0b6144e6e22072a000d8fd9
parent9846da2c9d0098bd3bbace16865aec9c463669a3 (diff)
printk: Fix missing klogd wakeup
The RT check for !in_atomic() && !irqs_disabled()) to prevent the klogd wakeup is actually bogus as wake_up_klogd() is just setting the needs print flag which is then evaluated from printk_tick() which does the actual wakeup. Reported-by: Nikita V. Youshchenko <yoush@cs.msu.su> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--kernel/printk.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/kernel/printk.c b/kernel/printk.c
index 073d27ffc128..bbce874de364 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1087,15 +1087,6 @@ void release_console_mutex(void)
raw_spin_unlock_irqrestore(&logbuf_lock, flags);
mutex_unlock(&console_mutex);
- /*
- * On PREEMPT_RT kernels __wake_up may sleep, so wake syslogd
- * up only if we are in a preemptible section. We normally dont
- * printk from non-preemptible sections so this is for the emergency
- * case only.
- */
-#ifdef CONFIG_PREEMPT_RT
- if (!in_atomic() && !irqs_disabled())
-#endif
if (wake_klogd)
wake_up_klogd();
}