diff options
| author | Salva Peiró <speiro@ai2.upv.es> | 2013-10-16 12:46:50 +0200 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2013-10-25 10:53:04 +0100 |
| commit | 5ab996fb130fc74e8b34e4501133fbbed5bd18c0 (patch) | |
| tree | 7b75a7d01df6676b5075ec6ab9cb380c764cfd3f | |
| parent | c6f203f8377a1d6848413db51c172583276568ce (diff) | |
wanxl: fix info leak in ioctl
commit 2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 upstream.
The wanxl_ioctl() code fails to initialize the two padding bytes of
struct sync_serial_settings after the ->loopback member. Add an explicit
memset(0) before filling the structure to avoid the info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
| -rw-r--r-- | drivers/net/wan/wanxl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index feb7541b33fb..ccd496bf32d9 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ifr->ifr_settings.size = size; /* data size wanted */ return -ENOBUFS; } + memset(&line, 0, sizeof(line)); line.clock_type = get_status(port)->clocking; line.clock_rate = 0; line.loopback = 0; |