diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-07-03 08:30:01 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@rostedt.homelinux.com> | 2013-09-13 12:32:32 -0400 |
commit | f8ecdb4d1dc6cd90a0236eec57ea9f282ea82510 (patch) | |
tree | 05e918f697e6a534d9b956f2abaa56fed5a8a57b /drivers | |
parent | 6d0be23c3fa222e5f4943b7527ef0bf76944a7ee (diff) |
serial: 8250: Clean up the locking for -rt
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/tty/serial/8250.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c index cff03e5c3316..f55f2241d2f9 100644 --- a/drivers/tty/serial/8250.c +++ b/drivers/tty/serial/8250.c @@ -2879,14 +2879,10 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count) touch_nmi_watchdog(); - local_irq_save(flags); - if (up->port.sysrq) { - /* serial8250_handle_port() already took the lock */ - locked = 0; - } else if (oops_in_progress) { - locked = spin_trylock(&up->port.lock); - } else - spin_lock(&up->port.lock); + if (up->port.sysrq || oops_in_progress) + locked = spin_trylock_irqsave(&up->port.lock, flags); + else + spin_lock_irqsave(&up->port.lock, flags); /* * First save the IER then disable the interrupts @@ -2918,8 +2914,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count) check_modem_status(up); if (locked) - spin_unlock(&up->port.lock); - local_irq_restore(flags); + spin_unlock_irqrestore(&up->port.lock, flags); } static int __init serial8250_console_setup(struct console *co, char *options) |