diff options
| author | Pratyush Anand <pratyush.anand@st.com> | 2013-01-14 15:59:38 +0530 |
|---|---|---|
| committer | Kamal Mostafa <kamal@canonical.com> | 2013-06-20 08:55:28 -0700 |
| commit | db47a57a53909747295c67bc507e2d0b7ccaf7f8 (patch) | |
| tree | 0f6774d407354f59b5cfaddc7ef00f61098ecdd1 /drivers | |
| parent | 2ab649ee9cd6c5e2bd8d29333301aadbdd047c0b (diff) | |
usb: dwc3: gadget: req->queued must be forced to false in cleanup
commit c9fda7d6f62a6520e01652d370654c5657d3c1a1 upstream.
I am not sure, why I found it during SG debugging. But, I noticed that
even when req_queued list was empty, there were some request in
request_list having queued flag true. If I run test second time, it
first removes all request from request_list and hence busy_slot was
wrongly incremented.
Signed-off-by: Pratyush Anand <pratyush.anand@st.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
[ luis: adjust context ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/dwc3/gadget.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 3c0351a37cac..be13492ba58e 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -256,6 +256,7 @@ void dwc3_gadget_giveback(struct dwc3_ep *dep, struct dwc3_request *req, if (((dep->busy_slot & DWC3_TRB_MASK) == DWC3_TRB_NUM - 1) && usb_endpoint_xfer_isoc(dep->endpoint.desc)) dep->busy_slot++; + req->queued = false; } list_del(&req->list); req->trb = NULL; |