diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2009-07-19 08:44:27 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2013-04-30 15:33:51 -0400 |
| commit | de2b37169dcfe934a14e31aa77425e30e69cc46d (patch) | |
| tree | 6e38321304c287ca4707733d378968af71cd1202 /fs | |
| parent | 35b5df865f99e3e23d0970679f82fd70302d4018 (diff) | |
fs: namespace preemption fix
On RT we cannot loop with preemption disabled here as
mnt_make_readonly() might have been preempted. We can safely enable
preemption while waiting for MNT_WRITE_HOLD to be cleared. Safe on !RT
as well.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/namespace.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/namespace.c b/fs/namespace.c index 4e465397e456..6dc617cd900b 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -313,8 +313,11 @@ int mnt_want_write(struct vfsmount *m) * incremented count after it has set MNT_WRITE_HOLD. */ smp_mb(); - while (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) + while (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) { + preempt_enable(); cpu_relax(); + preempt_disable(); + } /* * After the slowpath clears MNT_WRITE_HOLD, mnt_is_readonly will * be set to match its requirements. So we must not load that until |