diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2015-10-22 09:03:12 +1100 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2015-10-22 09:03:12 +1100 |
commit | d3fa27ff2c72d7e7424ebcfb60260b5299611282 (patch) | |
tree | d01c09167f27bf91bbf2cf22478b8b467f30658f /fs | |
parent | 3795d2475f151e305b3c3f0d7a6f768305030c6e (diff) |
mm-fs-introduce-mapping_gfp_constraint-checkpatch-fixes
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#46: FILE: drivers/gpu/drm/drm_gem.c:494:
+ BUG_ON(mapping_gfp_constraint(mapping, __GFP_DMA32) &&
WARNING: line over 80 characters
#73: FILE: fs/btrfs/compression.c:485:
+ page = __page_cache_alloc(mapping_gfp_constraint(mapping, ~__GFP_FS));
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#183: FILE: fs/logfs/segment.c:60:
+ BUG_ON(mapping_gfp_constraint(mapping, __GFP_FS));
WARNING: line over 80 characters
#228: FILE: fs/nilfs2/inode.c:359:
+ mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS));
WARNING: line over 80 characters
#237: FILE: fs/nilfs2/inode.c:525:
+ mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS));
WARNING: line over 80 characters
#249: FILE: fs/ntfs/file.c:529:
+ mapping_gfp_constraint(mapping, GFP_KERNEL));
WARNING: line over 80 characters
#261: FILE: fs/splice.c:363:
+ mapping_gfp_constraint(mapping, GFP_KERNEL));
WARNING: line over 80 characters
#290: FILE: mm/filemap.c:1725:
+ mapping_gfp_constraint(mapping, GFP_KERNEL));
total: 0 errors, 8 warnings, 205 lines checked
./patches/mm-fs-introduce-mapping_gfp_constraint.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/btrfs/compression.c | 6 | ||||
-rw-r--r-- | fs/nilfs2/inode.c | 4 | ||||
-rw-r--r-- | fs/ntfs/file.c | 4 | ||||
-rw-r--r-- | fs/splice.c | 2 |
4 files changed, 8 insertions, 8 deletions
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 147a9761e47f..36dfeff2c1f4 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -482,12 +482,12 @@ static noinline int add_ra_bio_pages(struct inode *inode, goto next; } - page = __page_cache_alloc(mapping_gfp_constraint(mapping, ~__GFP_FS)); + page = __page_cache_alloc(mapping_gfp_constraint(mapping, + ~__GFP_FS)); if (!page) break; - if (add_to_page_cache_lru(page, mapping, pg_index, - GFP_NOFS)) { + if (add_to_page_cache_lru(page, mapping, pg_index, GFP_NOFS)) { page_cache_release(page); goto next; } diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index b2ee592d48d2..ac2f64943ff4 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c @@ -356,7 +356,7 @@ struct inode *nilfs_new_inode(struct inode *dir, umode_t mode) goto failed; mapping_set_gfp_mask(inode->i_mapping, - mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS)); + mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS)); root = NILFS_I(dir)->i_root; ii = NILFS_I(inode); @@ -522,7 +522,7 @@ static int __nilfs_read_inode(struct super_block *sb, up_read(&NILFS_MDT(nilfs->ns_dat)->mi_sem); nilfs_set_inode_flags(inode); mapping_set_gfp_mask(inode->i_mapping, - mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS)); + mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS)); return 0; failed_unmap: diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 916e3efeaa0e..9d383e5eff0e 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -525,8 +525,8 @@ static inline int __ntfs_grab_cache_pages(struct address_space *mapping, } } err = add_to_page_cache_lru(*cached_page, mapping, - index, - mapping_gfp_constraint(mapping, GFP_KERNEL)); + index, + mapping_gfp_constraint(mapping, GFP_KERNEL)); if (unlikely(err)) { if (err == -EEXIST) continue; diff --git a/fs/splice.c b/fs/splice.c index 9ce27b1e9690..801c21cd77fe 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -360,7 +360,7 @@ __generic_file_splice_read(struct file *in, loff_t *ppos, break; error = add_to_page_cache_lru(page, mapping, index, - mapping_gfp_constraint(mapping, GFP_KERNEL)); + mapping_gfp_constraint(mapping, GFP_KERNEL)); if (unlikely(error)) { page_cache_release(page); if (error == -EEXIST) |