From 71cf6d3ee9351d668e9374d4026bf3337540eb22 Mon Sep 17 00:00:00 2001 From: H Hartley Sweeten Date: Wed, 19 Dec 2012 15:45:34 -0700 Subject: staging: comedi: comedi_fops: use kzalloc in comedi_alloc_subdevice_minor() The hardware_device member of comedi_file_info is not set in this function. Use kzalloc to make sure this pointer does not contain invalid data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/comedi/comedi_fops.c') diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 2826a29479c2..dda47b161bcf 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2376,8 +2376,8 @@ int comedi_alloc_subdevice_minor(struct comedi_device *dev, struct device *csdev; unsigned i; - info = kmalloc(sizeof(*info), GFP_KERNEL); - if (info == NULL) + info = kzalloc(sizeof(*info), GFP_KERNEL); + if (!info) return -ENOMEM; info->device = dev; info->read_subdevice = s; -- cgit v1.2.3