aboutsummaryrefslogtreecommitdiff
path: root/drivers/cpuidle
diff options
context:
space:
mode:
authorMilton Miller <miltonm@bga.com>2010-02-19 17:44:42 +0000
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-02 09:46:42 -0500
commit8c948adceb2bacfb26ba80b565f75f488064b111 (patch)
tree2de1b339e8ea62bd7e53ff8f4405d8528c693610 /drivers/cpuidle
parent01eda7c1aeb6f9a36fdf6f6233609c55fd194745 (diff)
ixgbe: prevent speculative processing of descriptors before ready
commit 3c945e5b3719bcc18c6ddd31bbcae8ef94f3d19a upstream. The PowerPC architecture does not require loads to independent bytes to be ordered without adding an explicit barrier. In ixgbe_clean_rx_irq we load the status bit then load the packet data. With packet split disabled if these loads go out of order we get a stale packet, but we will notice the bad sequence numbers and drop it. The problem occurs with packet split enabled where the TCP/IP header and data are in different descriptors. If the reads go out of order we may have data that doesn't match the TCP/IP header. Since we use hardware checksumming this bad data is never verified and it makes it all the way to the application. This bug was found during stress testing and adding this barrier has been shown to fix it. Signed-off-by: Milton Miller <miltonm@bga.com> Signed-off-by: Anton Blanchard <anton@samba.org> Acked-by: Don Skidmore <donald.c.skidmore@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> Cc: maximilian attems <max@stro.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/cpuidle')
0 files changed, 0 insertions, 0 deletions