diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2014-09-08 10:46:23 +0100 |
|---|---|---|
| committer | Andrey Konovalov <andrey.konovalov@linaro.org> | 2014-10-08 21:05:00 +0400 |
| commit | 72678ed8397eff9245b379ff3e445ebaf086cd66 (patch) | |
| tree | 805440b44db147179ecca1ff7c991f8547d6635b | |
| parent | 936fad9ea25588e3c2229ba1a9515119b7ff07c2 (diff) | |
mmc: mmci_qcom_dml: fix is never less than zero warning.
This patch fixes a typo which resulted in 'is never less
than zero warning' reported by static checker.
drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init()
warn: unsigned 'producer_id' is never less than zero.
drivers/mmc/host/mmci_qcom_dml.c
121 /* Initialize the dml hardware connected to SD Card controller */
122 int dml_hw_init(struct mmci_host *host, struct device_node *np)
123 {
124 u32 config;
125 void __iomem *base;
126 u32 consumer_id, producer_id;
127
128 consumer_id = of_get_dml_pipe_index(np, "tx");
129 producer_id = of_get_dml_pipe_index(np, "rx");
130
131 if (producer_id < 0 || consumer_id < 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
132
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
| -rw-r--r-- | drivers/mmc/host/mmci_qcom_dml.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c index 300ef50636cb..2b7fc3764803 100644 --- a/drivers/mmc/host/mmci_qcom_dml.c +++ b/drivers/mmc/host/mmci_qcom_dml.c @@ -123,7 +123,7 @@ int dml_hw_init(struct mmci_host *host, struct device_node *np) { u32 config; void __iomem *base; - u32 consumer_id, producer_id; + int consumer_id, producer_id; consumer_id = of_get_dml_pipe_index(np, "tx"); producer_id = of_get_dml_pipe_index(np, "rx"); |