summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRui Miguel Silva <rui.silva@linaro.org>2018-02-20 23:34:40 +0000
committerBryan O'Donoghue <bryan.odonoghue@linaro.org>2019-05-01 11:51:26 +0100
commit6c21bfbaf42d4f960a983e9d83777bbe72aa014c (patch)
tree29bfc5ec670f81d4cd084b9b9b353766642b8b76
parent0f6dc7cfe9b2a2f4c928e6678aede33e4643fd02 (diff)
media: ov2680: adjust direct mode register settings
Adjust the default values for direct mode register settings for 1600x1200 and 1280x720 to avoid some observed corruption in captured frames. While at it, remove unused init settings as we are using the 800x600 as the initial mode. Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
-rw-r--r--drivers/media/i2c/ov2680.c31
1 files changed, 9 insertions, 22 deletions
diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index fd2fda2eaf8e..03ee5b5c34ea 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -131,19 +131,6 @@ static const char * const test_pattern_menu[] = {
"Black Image",
};
-static const struct reg_value ov2680_init_settings[] = {
- {0x3002, 0x00}, {0x3016, 0x1c}, {0x3082, 0x45}, {0x350b, 0x36},
- {0x3600, 0xb4}, {0x3603, 0x39}, {0x3604, 0x24}, {0x3605, 0x00},
- {0x3620, 0x26}, {0x3621, 0x37}, {0x3622, 0x04}, {0x3628, 0x00},
- {0x3701, 0x64}, {0x3784, 0x0c}, {0x3705, 0x3c}, {0x370c, 0x50},
- {0x370d, 0xc0}, {0x3718, 0x88}, {0x3720, 0x00}, {0x3721, 0x00},
- {0x3722, 0x00}, {0x3723, 0x00}, {0x3738, 0x00}, {0x3717, 0x58},
- {0x3781, 0x80}, {0x3789, 0x60}, {0x4000, 0x81}, {0x4602, 0x02},
- {0x481f, 0x36}, {0x4825, 0x36}, {0x5000, 0x3f}, {0x5002, 0x30},
- {0x5780, 0x3e}, {0x5788, 0x02}, {0x578e, 0x08}, {0x578f, 0x0c},
- {0x5792, 0x00},
-};
-
static const struct reg_value ov2680_setting_30fps_QUXGA_800_600[] = {
{0x3086, 0x01}, {0x370a, 0x23}, {0x3808, 0x03}, {0x3809, 0x20},
{0x380a, 0x02}, {0x380b, 0x58}, {0x380c, 0x06}, {0x380d, 0xac},
@@ -153,18 +140,18 @@ static const struct reg_value ov2680_setting_30fps_QUXGA_800_600[] = {
};
static const struct reg_value ov2680_setting_30fps_720P_1280_720[] = {
- {0x3086, 0x00}, {0x370a, 0x23}, {0x3808, 0x05}, {0x3809, 0x00},
- {0x380a, 0x02}, {0x380b, 0xd0}, {0x380c, 0x06}, {0x380d, 0xa8},
- {0x380e, 0x05}, {0x380f, 0x0e}, {0x3811, 0x08}, {0x3813, 0x06},
- {0x3814, 0x11}, {0x3815, 0x11}, {0x3820, 0xc0}, {0x4008, 0x00},
+ {0x3086, 0x00}, {0x3808, 0x05}, {0x3809, 0x00}, {0x380a, 0x02},
+ {0x380b, 0xd0}, {0x380c, 0x06}, {0x380d, 0xa8}, {0x380e, 0x05},
+ {0x380f, 0x0e}, {0x3811, 0x08}, {0x3813, 0x06}, {0x3814, 0x11},
+ {0x3815, 0x11}, {0x3820, 0xc0}, {0x4008, 0x00},
};
static const struct reg_value ov2680_setting_30fps_UXGA_1600_1200[] = {
- {0x3086, 0x01}, {0x370a, 0x23}, {0x3808, 0x06}, {0x3809, 0x40},
- {0x380a, 0x04}, {0x380b, 0xb0}, {0x380c, 0x06}, {0x380d, 0xac},
- {0x380e, 0x05}, {0x380f, 0x0e}, {0x3811, 0x00}, {0x3813, 0x00},
- {0x3814, 0x11}, {0x3815, 0x11}, {0x3820, 0xc0}, {0x4008, 0x00},
- {0x3501, 0x4e}, {0x3502, 0xe0},
+ {0x3086, 0x00}, {0x3501, 0x4e}, {0x3502, 0xe0}, {0x3808, 0x06},
+ {0x3809, 0x40}, {0x380a, 0x04}, {0x380b, 0xb0}, {0x380c, 0x06},
+ {0x380d, 0xa8}, {0x380e, 0x05}, {0x380f, 0x0e}, {0x3811, 0x00},
+ {0x3813, 0x00}, {0x3814, 0x11}, {0x3815, 0x11}, {0x3820, 0xc0},
+ {0x4008, 0x00}, {0x4837, 0x18}
};
static const struct ov2680_mode_info ov2680_mode_init_data = {