diff options
| author | Vinod Koul <vkoul@kernel.org> | 2021-11-17 11:48:05 +0530 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-11-17 17:46:59 +0530 |
| commit | 0f6bacc4f7d4f266ff9b3ec8e756a6da9ea95af3 (patch) | |
| tree | 31ffe784abd0de5f99fbe3cc2bee86d8b300fc00 | |
| parent | 9a23004a053ce00caedaf1eb4291471577bc06cd (diff) | |
spi: qcom: geni: set the error code for gpi transfer
Before we invoke spi_finalize_current_transfer() in
spi_gsi_callback_result() we should set the spi->cur_msg->status as
appropriate (0 for success, error otherwise).
The helps to return error on transfer and not wait till it timesout on
error
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/spi/spi-geni-qcom.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 413fa1a7a936..b9769de1f5f0 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -346,17 +346,20 @@ spi_gsi_callback_result(void *cb, const struct dmaengine_result *result) { struct spi_master *spi = cb; + spi->cur_msg->status = -EIO; if (result->result != DMA_TRANS_NOERROR) { dev_err(&spi->dev, "DMA txn failed: %d\n", result->result); return; } if (!result->residue) { + spi->cur_msg->status = 0; dev_dbg(&spi->dev, "DMA txn completed\n"); - spi_finalize_current_transfer(spi); } else { dev_err(&spi->dev, "DMA xfer has pending: %d\n", result->residue); } + + spi_finalize_current_transfer(spi); } static int setup_gsi_xfer(struct spi_transfer *xfer, struct spi_geni_master *mas, |