aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkargl <kargl@138bc75d-0d04-0410-961f-82ee72b054a4>2019-08-30 23:19:30 +0000
committerkargl <kargl@138bc75d-0d04-0410-961f-82ee72b054a4>2019-08-30 23:19:30 +0000
commit67dcc024e5f921f3137363550dbb3b2e923fbde0 (patch)
treed06d61ab8fde48ca5f58b56868678320a93065e3
parentd33bb3d3543312b3b377311c62fce539b5584ebc (diff)
2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/91564 * check.c (gfc_check_kill_sub): Additional checks on status dummy argument. 2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/91564 * gfortran.dg/pr91564.f90: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-9-branch@275229 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/fortran/ChangeLog6
-rw-r--r--gcc/fortran/check.c16
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gfortran.dg/pr91564.f9016
4 files changed, 43 insertions, 0 deletions
diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 3a9e7d393b8..52c6a8121f6 100644
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,5 +1,11 @@
2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org>
+ PR fortran/91564
+ * check.c (gfc_check_kill_sub): Additional checks on status dummy
+ argument.
+
+2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org>
+
PR fortran/91551
* intrinsic.c (sort_actual): ALLOCATED has one argument. Check for
no argument case.
diff --git a/gcc/fortran/check.c b/gcc/fortran/check.c
index b0e002034ad..265fb1fda53 100644
--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -2785,6 +2785,22 @@ gfc_check_kill_sub (gfc_expr *pid, gfc_expr *sig, gfc_expr *status)
if (!scalar_check (status, 2))
return false;
+
+ if (status->expr_type != EXPR_VARIABLE)
+ {
+ gfc_error ("STATUS at %L shall be an INTENT(OUT) variable",
+ &status->where);
+ return false;
+ }
+
+ if (status->expr_type == EXPR_VARIABLE
+ && status->symtree && status->symtree->n.sym
+ && status->symtree->n.sym->attr.intent == INTENT_IN)
+ {
+ gfc_error ("%qs at %L shall be an INTENT(OUT) variable",
+ status->symtree->name, &status->where);
+ return false;
+ }
}
return true;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f2cc5e6fcb7..dc0d7f48f1e 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org>
+ PR fortran/91564
+ * gfortran.dg/pr91564.f90: New test.
+
+2019-08-30 Steven G. Kargl <kargl@gcc.gnu.org>
+
PR fortran/91551
* gfortran.dg/allocated_3.f90
diff --git a/gcc/testsuite/gfortran.dg/pr91564.f90 b/gcc/testsuite/gfortran.dg/pr91564.f90
new file mode 100644
index 00000000000..57783abe1f8
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr91564.f90
@@ -0,0 +1,16 @@
+! { dg-do compile }
+! PR fortran/91564
+! Contributed by Gerhard Steinmetz.
+program p
+ integer i, j
+ call kill (1, 2, 3) ! { dg-error "shall be an INTENT" }
+ i = 42
+ call bar(i, j)
+end
+
+subroutine bar(n, m)
+ integer, intent(in) :: n
+ integer, intent(inout) :: m
+ call kill (1, 3, n) ! { dg-error "shall be an INTENT" }
+ call kill (1, 3, m)
+end subroutine bar