diff options
author | mpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4> | 2019-09-01 22:59:10 +0000 |
---|---|---|
committer | mpolacek <mpolacek@138bc75d-0d04-0410-961f-82ee72b054a4> | 2019-09-01 22:59:10 +0000 |
commit | 875bf11237281a062ac3fe39c6fbdd07b2b90ad8 (patch) | |
tree | 576fe28593e637ba0421d647646d48f927025822 | |
parent | 35d794ced62574fc122cccf38a08afd2efeb6bc6 (diff) |
PR c++/91129 - wrong error with binary op in template argument.
* typeck.c (warn_for_null_address): Use fold_for_warn instead of
fold_non_dependent_expr.
(cp_build_binary_op): Likewise.
* g++.dg/cpp1y/nontype1.C: New test.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-9-branch@275286 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r-- | gcc/cp/ChangeLog | 10 | ||||
-rw-r--r-- | gcc/cp/typeck.c | 18 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/cpp1y/nontype1.C | 42 |
3 files changed, 59 insertions, 11 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index da73772c99e..fc78b3f24b4 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,13 @@ +2019-09-01 Marek Polacek <polacek@redhat.com> + + Backported from mainline + 2019-09-01 Marek Polacek <polacek@redhat.com> + + PR c++/91129 - wrong error with binary op in template argument. + * typeck.c (warn_for_null_address): Use fold_for_warn instead of + fold_non_dependent_expr. + (cp_build_binary_op): Likewise. + 2019-08-31 Iain Sandoe <iain@sandoe.co.uk> Backported from mainline diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c index bc4a7606582..c815bf3368c 100644 --- a/gcc/cp/typeck.c +++ b/gcc/cp/typeck.c @@ -4309,7 +4309,7 @@ warn_for_null_address (location_t location, tree op, tsubst_flags_t complain) || TREE_NO_WARNING (op)) return; - tree cop = fold_non_dependent_expr (op, complain); + tree cop = fold_for_warn (op); if (TREE_CODE (cop) == ADDR_EXPR && decl_with_nonnull_addr_p (TREE_OPERAND (cop, 0)) @@ -4632,9 +4632,8 @@ cp_build_binary_op (const op_location_t &location, || code1 == COMPLEX_TYPE || code1 == VECTOR_TYPE)) { enum tree_code tcode0 = code0, tcode1 = code1; - tree cop1 = fold_non_dependent_expr (op1, complain); doing_div_or_mod = true; - warn_for_div_by_zero (location, cop1); + warn_for_div_by_zero (location, fold_for_warn (op1)); if (tcode0 == COMPLEX_TYPE || tcode0 == VECTOR_TYPE) tcode0 = TREE_CODE (TREE_TYPE (TREE_TYPE (op0))); @@ -4673,11 +4672,8 @@ cp_build_binary_op (const op_location_t &location, case TRUNC_MOD_EXPR: case FLOOR_MOD_EXPR: - { - tree cop1 = fold_non_dependent_expr (op1, complain); - doing_div_or_mod = true; - warn_for_div_by_zero (location, cop1); - } + doing_div_or_mod = true; + warn_for_div_by_zero (location, fold_for_warn (op1)); if (code0 == VECTOR_TYPE && code1 == VECTOR_TYPE && TREE_CODE (TREE_TYPE (type0)) == INTEGER_TYPE @@ -4770,7 +4766,7 @@ cp_build_binary_op (const op_location_t &location, } else if (code0 == INTEGER_TYPE && code1 == INTEGER_TYPE) { - tree const_op1 = fold_non_dependent_expr (op1, complain); + tree const_op1 = fold_for_warn (op1); if (TREE_CODE (const_op1) != INTEGER_CST) const_op1 = op1; result_type = type0; @@ -4816,10 +4812,10 @@ cp_build_binary_op (const op_location_t &location, } else if (code0 == INTEGER_TYPE && code1 == INTEGER_TYPE) { - tree const_op0 = fold_non_dependent_expr (op0, complain); + tree const_op0 = fold_for_warn (op0); if (TREE_CODE (const_op0) != INTEGER_CST) const_op0 = op0; - tree const_op1 = fold_non_dependent_expr (op1, complain); + tree const_op1 = fold_for_warn (op1); if (TREE_CODE (const_op1) != INTEGER_CST) const_op1 = op1; result_type = type0; diff --git a/gcc/testsuite/g++.dg/cpp1y/nontype1.C b/gcc/testsuite/g++.dg/cpp1y/nontype1.C new file mode 100644 index 00000000000..a37e996a3ff --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1y/nontype1.C @@ -0,0 +1,42 @@ +// PR c++/91129 - wrong error with binary op in template argument. +// { dg-do compile { target c++14 } } + +template<class T, T v> +struct C +{ + constexpr operator T() const { return v; } + constexpr auto operator()() const { return v; } +}; + +template<class T, int N> +struct A +{ +}; + +template<int N> +void foo () +{ + A<int, C<int, 6>{}> a0; + A<int, !C<int, 6>{}> a1; + A<int, N / C<int, 6>{}> a2; + A<int, N % C<int, 6>{}> a3; + A<int, N * C<int, 6>{}> a4; + A<int, N ^ C<int, 6>{}> a5; + A<int, N | C<int, 6>{}> a6; + A<int, N & C<int, 6>{}> a7; + A<int, N + C<int, 6>{}> a8; + A<int, N - C<int, 6>{}> a9; + A<int, -C<int, 6>{}> a10; + A<int, (N >> C<int, 6>{})> a11; + A<int, N << C<int, 6>{}> a12; + A<int, ~C<int, 6>{}> a13; + A<int, N || C<int, 6>{}> a14; + A<int, N && C<int, 6>{}> a15; + A<int, N == C<int, 6>{}> a16; + A<int, N != C<int, 6>{}> a17; +} + +int main() +{ + foo<10>(); +} |