diff options
| author | Sriraman Tallam <tmsriram@google.com> | 2015-02-19 18:41:54 +0000 |
|---|---|---|
| committer | Sriraman Tallam <tmsriram@google.com> | 2015-02-19 18:41:54 +0000 |
| commit | c51f87068f84dc81543fef1f68220265554a91e2 (patch) | |
| tree | b796a05d8324e9ad9d78497653b90766e861f9b4 | |
| parent | 11f3c874c6cf8e2f44d3690095275f9485749b1d (diff) | |
Fix comment on why Weak Defined global symbols with fPIE
can be treated as local.
git-svn-id: https://gcc.gnu.org/svn/gcc/branches/google/gcc-4_9@220820 138bc75d-0d04-0410-961f-82ee72b054a4
| -rw-r--r-- | gcc/config/i386/i386.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index da7abc9628c..7b33288472a 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -13008,9 +13008,11 @@ legitimate_pic_address_disp_p (rtx disp) || (HAVE_LD_PIE_COPYRELOC && flag_pie && !(SYMBOL_REF_WEAK (op0) - /* TODO:Temporary fix for weak defined symbols. + /* TODO:Temporary fix for weak defined symbols. Weak defined + symbols in an executable cannot be overridden even with + a non-weak symbol in a shared library. Revert after fix is checked in here: - https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00366.html*/ + http://gcc.gnu.org/ml/gcc-patches/2015-02/msg00366.html*/ && SYMBOL_REF_EXTERNAL_P (op0)) && !SYMBOL_REF_FUNCTION_P (op0))) && ix86_cmodel != CM_LARGE_PIC) |