diff options
author | Sriraman Tallam <tmsriram@google.com> | 2013-07-10 02:25:59 +0000 |
---|---|---|
committer | Sriraman Tallam <tmsriram@google.com> | 2013-07-10 02:25:59 +0000 |
commit | 390c84fa7545fa24ed30835ed7f04f8191fa4f91 (patch) | |
tree | fac2c94e55799099d0c334767d6372a61980ff15 | |
parent | 77cbaeb15a61f7de05a55110b93a56c8d394ad93 (diff) |
Google ref b/9752504
Backport trunk rev. 194098 to not discard side-effects from expressions of nullptr_t.
Changed TYPE_PTRDATAMEM_P in cp/cvt.c to TYPE_PTRMEM_P. TYPE_PTRMEM_P was redefined to TYPE_PTRDATAMEM_P in trunk.
git-svn-id: https://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7@200861 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r-- | gcc/cp/cvt.c | 18 | ||||
-rw-r--r-- | gcc/cp/typeck.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/cpp0x/lambda/lambda-nullptr.C | 47 |
3 files changed, 56 insertions, 11 deletions
diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c index c411a47f0a8..f68ce903471 100644 --- a/gcc/cp/cvt.c +++ b/gcc/cp/cvt.c @@ -207,16 +207,14 @@ cp_convert_to_pointer (tree type, tree expr) return build_ptrmemfunc (TYPE_PTRMEMFUNC_FN_TYPE (type), expr, 0, /*c_cast_p=*/false, tf_warning_or_error); - if (TYPE_PTRMEM_P (type)) - { - /* A NULL pointer-to-member is represented by -1, not by - zero. */ - expr = build_int_cst_type (type, -1); - } - else - expr = build_int_cst (type, 0); - - return expr; + /* A NULL pointer-to-data-member is represented by -1, not by + zero. */ + tree val = (TYPE_PTRMEM_P (type) + ? build_int_cst_type (type, -1) + : build_int_cst (type, 0)); + + return (TREE_SIDE_EFFECTS (expr) + ? build2 (COMPOUND_EXPR, type, expr, val) : val); } else if (TYPE_PTR_TO_MEMBER_P (type) && INTEGRAL_CODE_P (form)) { diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c index 5ae012e9cbb..b5ccfdefbd6 100644 --- a/gcc/cp/typeck.c +++ b/gcc/cp/typeck.c @@ -7251,7 +7251,7 @@ build_ptrmemfunc (tree type, tree pfn, int force, bool c_cast_p, /* Handle null pointer to member function conversions. */ if (null_ptr_cst_p (pfn)) { - pfn = build_c_cast (input_location, type, nullptr_node); + pfn = build_c_cast (input_location, type, pfn); return build_ptrmemfunc1 (to_type, integer_zero_node, pfn); diff --git a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-nullptr.C b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-nullptr.C new file mode 100644 index 00000000000..1aadbb490dc --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-nullptr.C @@ -0,0 +1,47 @@ +// PR c++/54170 +// { dg-do run { target c++11 } } + +#include <cassert> + +struct A; +typedef A* ptr; +typedef int (A::*pmf) (int); +typedef int (A::*pdm); + +int total; + +void add(int n) +{ + total += n; +} + +template <typename RType, typename Callable> +RType Call(Callable native_func, int arg) +{ + return native_func(arg); +} + +template <typename RType> +RType do_test(int delta) +{ + return Call<RType>([=](int delta) { add(delta); return nullptr; }, delta); +} + +template <typename RType> +void test() +{ + total = 0; + assert (!do_test<RType>(5)); + assert (total == 5); + assert (!do_test<RType>(20)); + assert (total == 25); + assert (!do_test<RType>(-256)); + assert (total == -231); +} + +int main() +{ + test<ptr>(); + test<pdm>(); + test<pmf>(); +} |