From 3ee9ae74ba4a85c3b378a0e49ec1481655f54500 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Mon, 13 May 2019 11:41:39 +0200 Subject: of_net: Fix missing of_find_device_by_node ref count drop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit of_find_device_by_node takes a reference to the embedded struct device which needs to be dropped after use. Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") Reported-by: kbuild test robot Reported-by: Julia Lawall Signed-off-by: Petr Štetiar Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller --- drivers/of/of_net.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c index a4b392a5406b..6f1be80e8c4e 100644 --- a/drivers/of/of_net.c +++ b/drivers/of/of_net.c @@ -60,10 +60,13 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np) return ERR_PTR(-ENODEV); ret = nvmem_get_mac_address(&pdev->dev, &nvmem_mac); - if (ret) + if (ret) { + put_device(&pdev->dev); return ERR_PTR(ret); + } mac = devm_kmemdup(&pdev->dev, nvmem_mac, ETH_ALEN, GFP_KERNEL); + put_device(&pdev->dev); if (!mac) return ERR_PTR(-ENOMEM); -- cgit v1.2.3