aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2023-11-06 14:04:01 +0100
committerPeter Zijlstra <peterz@infradead.org>2023-11-15 09:57:49 +0100
commitc708a4dc5ab547edc3d6537233ca9e79ea30ce47 (patch)
tree5df8aa2e65eac339d014d66f4334fd4e25b37a34
parent5fe6ec8f6ab549b6422e41551abb51802bd48bc7 (diff)
sched: Unify more update_curr*()
Now that trace_sched_stat_runtime() no longer takes a vruntime argument, the task specific bits are identical between update_curr_common() and update_curr(). Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
-rw-r--r--kernel/sched/fair.c24
1 files changed, 11 insertions, 13 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 33db70c6b582..1cd92b11b289 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1126,6 +1126,13 @@ static s64 update_curr_se(struct rq *rq, struct sched_entity *curr)
return delta_exec;
}
+static inline void update_curr_task(struct task_struct *p, s64 delta_exec)
+{
+ trace_sched_stat_runtime(p, delta_exec);
+ account_group_exec_runtime(p, delta_exec);
+ cgroup_account_cputime(p, delta_exec);
+}
+
/*
* Used by other classes to account runtime.
*/
@@ -1135,12 +1142,8 @@ s64 update_curr_common(struct rq *rq)
s64 delta_exec;
delta_exec = update_curr_se(rq, &curr->se);
- if (unlikely(delta_exec <= 0))
- return delta_exec;
-
- trace_sched_stat_runtime(curr, delta_exec);
- account_group_exec_runtime(curr, delta_exec);
- cgroup_account_cputime(curr, delta_exec);
+ if (likely(delta_exec > 0))
+ update_curr_task(curr, delta_exec);
return delta_exec;
}
@@ -1164,13 +1167,8 @@ static void update_curr(struct cfs_rq *cfs_rq)
update_deadline(cfs_rq, curr);
update_min_vruntime(cfs_rq);
- if (entity_is_task(curr)) {
- struct task_struct *curtask = task_of(curr);
-
- trace_sched_stat_runtime(curtask, delta_exec);
- cgroup_account_cputime(curtask, delta_exec);
- account_group_exec_runtime(curtask, delta_exec);
- }
+ if (entity_is_task(curr))
+ update_curr_task(task_of(curr), delta_exec);
account_cfs_rq_runtime(cfs_rq, delta_exec);
}