commands/record: Add checking for android targets

Update the 'package' argument description to specify it is for android
packages and add error checking to ensure that if specified, the target
supports android.

1 files changed, 5 insertions, 1 deletions

diff --git a/wa/commands/revent.py b/wa/commands/revent.py
index a27af92d..6eb885a6 100644
--- a/wa/commands/revent.py
+++ b/wa/commands/revent.py
@@ -81,7 +81,7 @@ class RecordCommand(Command):
         self.parser.add_argument('-C', '--clear', help='Clear app cache before launching it',
                                  action='store_true')
         group = self.parser.add_mutually_exclusive_group(required=False)
-        group.add_argument('-p', '--package', help='Package to launch before recording')
+        group.add_argument('-p', '--package', help='Android package to launch before recording')
         group.add_argument('-w', '--workload', help='Name of a revent workload (mostly games)')
 
     def validate_args(self, args):
@@ -161,6 +161,10 @@ class RecordCommand(Command):
         self.logger.info(msg.format(os.path.join(output_path, file_name)))
 
     def package_record(self, args):
+        if self.target.os != 'android' and self.target.os != 'chromeos':
+            raise ConfigError('Target does not appear to be running Android')
+        if self.target.os == 'chromeos' and not self.target.supports_android:
+            raise ConfigError('Target does not appear to support Android')
         if args.clear:
             self.target.execute('pm clear {}'.format(args.package))
         self.logger.info('Starting {}'.format(args.package))