diff options
| author | David Williams <david.williams@sonymobile.com> | 2012-11-19 09:52:16 +0100 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2012-11-20 12:27:56 -0800 |
| commit | d863eff90f2820e78da763ca5be9f942dc49675e (patch) | |
| tree | b4e343c70b5f0c15f4cdd22e2232771d8ba7c883 | |
| parent | 7013209cdf393b3d958ddd46ed50394349378826 (diff) | |
Avoid memory leaks when handling metadata strings
Don't duplicate strings when retrieveing metadata from media
files. As any requests for metadata strings would pass through
the binder, this would cause the reference to the duplicate string
to be lost, causing a memory leak as the duplicate would not be
freed.
Change-Id: I2593733472b1bb589bc502b2c11080f581015bb5
| -rw-r--r-- | media/libstagefright/StagefrightMetadataRetriever.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/libstagefright/StagefrightMetadataRetriever.cpp b/media/libstagefright/StagefrightMetadataRetriever.cpp index a2f3f134..19af4fbd 100644 --- a/media/libstagefright/StagefrightMetadataRetriever.cpp +++ b/media/libstagefright/StagefrightMetadataRetriever.cpp @@ -433,7 +433,7 @@ const char *StagefrightMetadataRetriever::extractMetadata(int keyCode) { return NULL; } - return strdup(mMetaData.valueAt(index).string()); + return mMetaData.valueAt(index).string(); } void StagefrightMetadataRetriever::parseMetaData() { |