Age | Commit message (Collapse) | Author |
|
Fix the syntax to get the current cpu id number with
the POSIX version.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Remove keywords such as "let", "typeset", and "local" that
are defined in BASH. Also, clean up any unused variables in
the process.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Remove signals that begin with SIG* since that is considered a
bashism. Use the POSIX-compliant version to list signals to be
used with the trap command.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Using double equals to evaluate whether two conditions are
equal is considered BASH syntax. The POSIX compliant version
uses one equal sign for evaluating.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
'source' is a BASH keyword. Edit the path to the library files by
using the POSIX version of the 'source' keyword.
Also change the interpreter from #!/bin/bash to #!/bin/sh.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Summary of changes in Version 0.4.15:
- Syntax errors in thermal scripts
- Not allow thermal governor to change cdev states
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
${array[1]} is the recommended way to dereference array elements in
bash. While $array[1] may work with some implementations of bash, it
is not guaranteed to work.
Signed-off-by: Javi Merino <javi.merino@arm.com>
Acked-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
check_scaling_freq() always passes due to a typo since it was
introduced in aa119586f05a (Verify the cpufreq cooling device are
clipping the frequencies). Fix the typo.
Signed-off-by: Javi Merino <javi.merino@arm.com>
Acked-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
thermal_04 disables thermal_zone0 during the test to prevent it from
changing the cooling state of the cooling devices while it runs.
Unfortunately, cooling devices can be bound to multiple thermal zones,
so a governor attached to another thermal zone can change the cooling
state and make the test fail.
Furthermore, the meaning of "enabled" and "disabled" is determined by
the platform code. Some platforms turn off polling but leave
interrupts enabled, so cooling device states may still be updated even
when the thermal zone is disabled.
Instead of just disabling thermal_zone0, change all the thermal
governors to user_space to prevent them from altering the states of
any cooling device while running the test.
Signed-off-by: Javi Merino <javi.merino@arm.com>
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
When running thermal_02, the thermal governor can decide to change the
cooling device state between setting the state and reading the state,
so this test may fail.
To prevent it, switch all the thermal zones to the user_space thermal
governor before running the test. This governor never touches cooling
devices.
Signed-off-by: Javi Merino <javi.merino@arm.com>
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Summary of changes in Version 0.4.14:
- Resolve the "ls: Unknown option '-1' error in Android
- Fix bug #386 to display all skipped tests in PM-QA
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Allow LAVA to record all the skipped test cases including
the ones that will not be executed due to failed
sanity checks. This enhancement will keep the number of PM-QA
results more consistent across multiple platforms.
Fix for Bug #386:
https://bugs.linaro.org/show_bug.cgi?id=386
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Resolve the "ls: Unknown option '-1'" error in the Android shell
by removing -1v option from ls command used to find number of
cpus on a platform.
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Acked-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Summary of changes in Version 0.4.13:
- Refactor pass/fail/skip code
- Update thermal subtest results to return pass/fail/skip instead
of ok/err/skip
- Check for root user in suspend module
- Move PM-QA to system/bin path for Android
- Remove hardcoded cpu number assumptions to test platforms with
more than 10 cpus
- Fix make error 1 build issues
- Add governor sampling rate to calculate scaling time in cpufreq
module
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Create a global variable that will look for number of cpus
for a platform and use it in multiple functions to make the
code simplier to read.
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Modify Test.mk to resolve the following build error:
make: [uncheck] Error 1 (ignored).
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
Remove the pass and fail count variables from the check()
function as all the pass/fail/skip counts are done inside
the log_end() function.
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
- execute permission for utils is removed when they are copied to
data/benchmark, moving pmqa to system/bin resolves this issue.
- bug : https://bugs.linaro.org/show_bug.cgi?id=156
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Focus on returning the results of each test script rather
than the results of each subtest. This will help to keep the
number of PM-QA test results consistent across multiple boards
regardless of number of frequencies, cores, etc.
Examples before the refactoring:
https://validation.linaro.org/dashboard/streams
/anonymous/lisatn/bundles/331786fb33a49b060adccf51bb509d5f286422e7/
Examples after the refactoring:
https://validation.linaro.org/dashboard/streams/anonymous
/lisatn/bundles/076a3f890e58727f01a23e30d6eb438172b69c7d/
Once this patch is accepted and merged, then there will be a
follow up patch to update the pwrmgmt test definition, so LAVA
can record PM-QA results accurately.
bug : https://bugs.linaro.org/show_bug.cgi?id=155
Acked-by: Sanjay Singh Rawat<sanjay.rawat@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
- add the governor sampling rate with the frequency transition latency to
make sure tansition happens.
- bug : https://bugs.linaro.org/show_bug.cgi?id=77
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- command (id) to check root user returns different output format
for ubuntu and android. Using generic function to avoid build
errors.
- bug 166
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
To make pm-qa consistent, all thermal subtests should say "ok" or
"err" instead of "pass" or "fail". The remaining subtests in pm-qa
follow the ok/err scheme.
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
|
|
- fix for cpuidle util time for panda [bug 152]
- test hotplugging on cpu0 if supported
- miscellaneous modification for proper lava result logs
- skip hotplug test on uniprocessor systems
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- fix for bug 152 on Panda, wait for more time for child to finish
- don't wait for child pid for offlined cpus
- bug 152
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
changing as required by lava
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
helps in readability
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- correct the test description
- increase the number of times cpuhotplug is performed to 100
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
helpful to keep test count same
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
lava searches for result pattern in the same line, adding _Err_
string in timeout case here
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
By default, cpuhotplug does not run on cpu0. However, if
we want to allow cpuhotplug to run on cpu0, then we must
pass the parameter, hotplug_allow_cpu0=1, to make check.
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
Reported-by: Milosz Wasilewski <milosz.wasilewski@linaro.org>
Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
|
|
for uniprocessor system hotplug test should not execute. Skip the
test in such case by handling in sanity file.
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- remove cpuidle stats subtest
- cpuhotplug_04: fix parsing pattern
- cpufreq: execute subtest completely
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- If the increase frequency test fails the test returns halfway.
This is affecting the number of tests reported in the logs,
removing it.
- bug 1304373
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
The -c option is to specify the cpu id list, without this option, the cpu
parameter is parsed as a cpumask.
We pass the -c with a cpumask which are mutually exclusive:
https://bugs.launchpad.net/bugs/1328066
Fix this by simply removing the '-c' argument.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
|
|
This reverts commit f698a6736fc105beca5feca8e5f5e4b6c97c41c8.
Removing as this has evolved to idlestat tool
https://wiki.linaro.org/WorkingGroups/PowerManagement/Resources/Tools/Idlestat
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- cpuidle_killer: allocate per cpu process array dynamically
- cpuidle: add cpu number in the cpuidle_killer logs for readability
- cpu-heat: fix miscellaneous issue
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
currently percpu process array is set to 2, for cpus >2 test
results in segfault
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- update on how android build the suite and how it can be
extended
- bug 1157644
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- fix android suspend case bug
- add util to read uevents from kerenl, for cpuhotplug userspace
notification. bug 1304251
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- This util reads the NETLINK socket to receive messages from the kernel.
For both ubuntu and android uevent_reader can be used to receive events.
- bug : 1304251
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
suspend android.mk is missing the sanity file entry, which will be
generated in out dir
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- bug : https://bugs.launchpad.net/linaro-power-qa/+bug/1290766
- removed test status function from sanity file
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
With test status function, the return status of the script run is
changed. Also there is no need of the status function in the sanity
check.
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
check for suspend support in the system
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
- added support to check feature before running suite
- cpuhotplug: skip hotplug for cpu0
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|
|
add a basic sanity file which will check for feature support and
will proceed only if feature supported
Signed-off-by: Sanjay Singh Rawat <sanjay.rawat@linaro.org>
|