59: force: #740: 21636: Failure after v6.2-rc3-45-gbd904f3c7496: udf: Unify types in anchor block detection

BUILD_URL: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/740/

Failure after v6.2-rc3-45-gbd904f3c7496: udf: Unify types in anchor block detection:

Results changed to
-10
# build_abe binutils:
-9
# build_kernel_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
21636
# First few build errors in logs:
# 01:01:50 fs/udf/super.c:1942:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
# 01:01:50 fs/udf/super.c:1950:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
# 01:01:50 fs/udf/super.c:1956:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
# 01:01:50 make[3]: *** [scripts/Makefile.build:252: fs/udf/super.o] Error 1
# 01:02:34 make[2]: *** [scripts/Makefile.build:504: fs/udf] Error 2
# 01:40:30 make[1]: *** [scripts/Makefile.build:504: fs] Error 2
# 01:55:42 make: *** [Makefile:2008: .] Error 2

from
-10
# build_abe binutils:
-9
# build_kernel_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
21715
# linux build successful:
all

5 files changed, 148 insertions, 0 deletions

diff --git a/jenkins/jira-status.draft b/jenkins/jira-status.draft
new file mode 100644
index 0000000..477235c
--- /dev/null
+++ b/jenkins/jira-status.draft
@@ -0,0 +1,4 @@
+[LLVM-647]
+#INTERESTING_COMMIT_STATUS#
+
+Details: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/740/artifact/artifacts/jenkins/mail-body.txt/*view*/
diff --git a/jenkins/mail-body.draft b/jenkins/mail-body.draft
new file mode 100644
index 0000000..f921f21
--- /dev/null
+++ b/jenkins/mail-body.draft
@@ -0,0 +1,139 @@
+Failure after v6.2-rc3-45-gbd904f3c7496: udf: Unify types in anchor block detection:
+
+Results changed to
+-10
+# build_abe binutils:
+-9
+# build_kernel_llvm:
+-5
+# build_abe qemu:
+-2
+# linux_n_obj:
+21636
+# First few build errors in logs:
+# 01:01:50 fs/udf/super.c:1942:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
+# 01:01:50 fs/udf/super.c:1950:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
+# 01:01:50 fs/udf/super.c:1956:29: error: incompatible pointer types passing 'sector_t *' (aka 'unsigned long long *') to parameter of type 'udf_pblk_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
+# 01:01:50 make[3]: *** [scripts/Makefile.build:252: fs/udf/super.o] Error 1
+# 01:02:34 make[2]: *** [scripts/Makefile.build:504: fs/udf] Error 2
+# 01:40:30 make[1]: *** [scripts/Makefile.build:504: fs] Error 2
+# 01:55:42 make: *** [Makefile:2008: .] Error 2
+
+from
+-10
+# build_abe binutils:
+-9
+# build_kernel_llvm:
+-5
+# build_abe qemu:
+-2
+# linux_n_obj:
+21715
+# linux build successful:
+all
+
+THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
+
+For latest status see comments in https://linaro.atlassian.net/browse/LLVM-647 .
+#INTERESTING_COMMIT_STATUS#
+
+Bad  build: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/740/artifact/artifacts
+Good build: https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/739/artifact/artifacts
+
+Reproduce current build:
+<cut>
+mkdir -p investigate-linux-bd904f3c74969442b0ac42f81c0d02da54cd47eb
+cd investigate-linux-bd904f3c74969442b0ac42f81c0d02da54cd47eb
+
+# Fetch scripts
+git clone https://git.linaro.org/toolchain/jenkins-scripts
+
+# Fetch manifests for bad and good builds
+mkdir -p bad/artifacts good/artifacts
+curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/740/artifact/artifacts/manifest.sh --fail
+curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/739/artifact/artifacts/manifest.sh --fail
+
+# Reproduce bad build
+(cd bad; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts)
+# Reproduce good build
+(cd good; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts)
+</cut>
+
+Full commit (up to 1000 lines):
+<cut>
+commit bd904f3c74969442b0ac42f81c0d02da54cd47eb
+Author: Jan Kara <jack@suse.cz>
+Date:   Wed Jan 18 13:55:31 2023 +0100
+
+    udf: Unify types in anchor block detection
+    
+    When detecting last recorded block and from it derived anchor block
+    position, we were mixing unsigned long, u32, and sector_t types. Since
+    udf supports only 32-bit block numbers this is harmless but sometimes
+    makes things awkward. Convert everything to udf_pblk_t and also handle
+    the situation when block device size would not fit into udf_pblk_t.
+    
+    Signed-off-by: Jan Kara <jack@suse.cz>
+---
+ fs/udf/lowlevel.c | 7 +++++--
+ fs/udf/super.c    | 4 ++--
+ fs/udf/udfdecl.h  | 2 +-
+ 3 files changed, 8 insertions(+), 5 deletions(-)
+
+diff --git a/fs/udf/lowlevel.c b/fs/udf/lowlevel.c
+index 46d697172197..c87ed942d076 100644
+--- a/fs/udf/lowlevel.c
++++ b/fs/udf/lowlevel.c
+@@ -45,7 +45,7 @@ unsigned int udf_get_last_session(struct super_block *sb)
+ 	return 0;
+ }
+ 
+-unsigned long udf_get_last_block(struct super_block *sb)
++udf_pblk_t udf_get_last_block(struct super_block *sb)
+ {
+ 	struct cdrom_device_info *cdi = disk_to_cdi(sb->s_bdev->bd_disk);
+ 	unsigned long lblock = 0;
+@@ -54,8 +54,11 @@ unsigned long udf_get_last_block(struct super_block *sb)
+ 	 * The cdrom layer call failed or returned obviously bogus value?
+ 	 * Try using the device size...
+ 	 */
+-	if (!cdi || cdrom_get_last_written(cdi, &lblock) || lblock == 0)
++	if (!cdi || cdrom_get_last_written(cdi, &lblock) || lblock == 0) {
++		if (sb_bdev_nr_blocks(sb) > ~(udf_pblk_t)0)
++			return 0;
+ 		lblock = sb_bdev_nr_blocks(sb);
++	}
+ 
+ 	if (lblock)
+ 		return lblock - 1;
+diff --git a/fs/udf/super.c b/fs/udf/super.c
+index 241b40e886b3..c756d903a862 100644
+--- a/fs/udf/super.c
++++ b/fs/udf/super.c
+@@ -1861,10 +1861,10 @@ static int udf_check_anchor_block(struct super_block *sb, sector_t block,
+  * Returns < 0 on error, 0 on success. -EAGAIN is special - try next set
+  * of anchors.
+  */
+-static int udf_scan_anchors(struct super_block *sb, sector_t *lastblock,
++static int udf_scan_anchors(struct super_block *sb, udf_pblk_t *lastblock,
+ 			    struct kernel_lb_addr *fileset)
+ {
+-	sector_t last[6];
++	udf_pblk_t last[6];
+ 	int i;
+ 	struct udf_sb_info *sbi = UDF_SB(sb);
+ 	int last_count = 0;
+diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
+index d35aa42bb577..eaf9e6fd201e 100644
+--- a/fs/udf/udfdecl.h
++++ b/fs/udf/udfdecl.h
+@@ -196,7 +196,7 @@ extern void udf_new_tag(char *, uint16_t, uint16_t, uint16_t, uint32_t, int);
+ 
+ /* lowlevel.c */
+ extern unsigned int udf_get_last_session(struct super_block *);
+-extern unsigned long udf_get_last_block(struct super_block *);
++udf_pblk_t udf_get_last_block(struct super_block *);
+ 
+ /* partition.c */
+ extern uint32_t udf_get_pblock(struct super_block *, uint32_t, uint16_t,
+</cut>
diff --git a/jenkins/mail-recipients.draft b/jenkins/mail-recipients.draft
new file mode 100644
index 0000000..15df677
--- /dev/null
+++ b/jenkins/mail-recipients.draft
@@ -0,0 +1 @@
+Jan Kara <jack@suse.cz>,cc:llvm@lists.linux.dev,cc:arnd@linaro.org
diff --git a/jenkins/mail-subject.draft b/jenkins/mail-subject.draft
new file mode 100644
index 0000000..230659a
--- /dev/null
+++ b/jenkins/mail-subject.draft
@@ -0,0 +1 @@
+[TCWG CI] Failure after v6.2-rc3-45-gbd904f3c7496: udf: Unify types in anchor block detection
diff --git a/jenkins/notify.sh b/jenkins/notify.sh
new file mode 100755
index 0000000..cd8732c
--- /dev/null
+++ b/jenkins/notify.sh
@@ -0,0 +1,3 @@
+#!/bin/bash
+
+/home/tcwg-buildslave/workspace/tcwg_kernel_0/jenkins-scripts/round-robin-notify.sh --artifacts "artifacts/jenkins" --BUILD_URL "https://ci.linaro.org/job/tcwg_kernel-llvm-build-llvm-master-aarch64-next-allyesconfig/740/" --ci_project "tcwg_kernel" --ci_config "llvm-master-aarch64-next-allyesconfig" --current_project "linux" --first_bad "bd904f3c74969442b0ac42f81c0d02da54cd47eb" --last_good "1ea1cd11c72d1405a6b98440a9d5ea82dfa07166" --summary "artifacts/mail/jira-body.txt"