summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Liu <ioeric@google.com>2018-10-02 10:28:54 +0000
committerEric Liu <ioeric@google.com>2018-10-02 10:28:54 +0000
commit05a705d1606560e8928d34cc2c2de90ad189ac70 (patch)
tree3bcb5c3b6ba0f5ee9feda4dc430f34e774f8e4ad
parentfe0dc2cdc246092b09a5c770d8ca77c676cfba8c (diff)
Revert untintentionally commited changes
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h b/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
index 828955dc100..d10b862ea08 100644
--- a/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
+++ b/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
@@ -79,9 +79,9 @@ class FieldNode {
protected:
const FieldRegion *FR;
- // TODO: This destructor shouldn't be virtual, but breaks buildbots with
- // -Werror -Wnon-virtual-dtor.
- virtual ~FieldNode() = default;
+ /// FieldNodes are never meant to be created on the heap, see
+ /// FindUninitializedFields::addFieldToUninits().
+ /* non-virtual */ ~FieldNode() = default;
public:
FieldNode(const FieldRegion *FR) : FR(FR) {}