diff options
author | Jonas Toth <jonas.toth@gmail.com> | 2018-10-04 15:59:30 +0000 |
---|---|---|
committer | Jonas Toth <jonas.toth@gmail.com> | 2018-10-04 15:59:30 +0000 |
commit | 0807b57f7fe6ac94d70144b29f2403e06e84cc7c (patch) | |
tree | ba602d4ccf46f005e93aba12bdfc37b537c6e9e3 | |
parent | 9b8ad4f2f95056502e0f89370705e6c058349cd3 (diff) |
[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
Reviewers: alexfh, aaron.ballman, hokein
Reviewed By: alexfh
Subscribers: xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D52688
-rw-r--r-- | clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp b/clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp index f7b1ae695c9..ce745651d50 100644 --- a/clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp +++ b/clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp @@ -1,14 +1,13 @@ // RUN: %check_clang_tidy %s fuchsia-default-arguments %t int foo(int value = 5) { return value; } -// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int foo(int value) { return value; } int f() { foo(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: - // CHECK-NEXT: int foo(int value = 5) { return value; } + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-8]]:9: note: default parameter was declared here } int bar(int value) { return value; } @@ -21,7 +20,7 @@ int n() { class Baz { public: int a(int value = 5) { return value; } - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int a(int value) { return value; } int b(int value) { return value; } @@ -30,7 +29,7 @@ public: class Foo { // Fix should be suggested in declaration int a(int value = 53); - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int a(int value); }; @@ -41,7 +40,7 @@ int Foo::a(int value) { // Elided functions void f(int = 5) {}; -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void f(int) {}; void g(int) {}; @@ -50,12 +49,12 @@ void g(int) {}; #define D(val) = val void h(int i D(5)); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES-NOT: void h(int i); void x(int i); void x(int i = 12); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void x(int i); void x(int i) {} @@ -65,17 +64,17 @@ struct S { }; void S::x(int i = 12) {} -// CHECK-MESSAGES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void S::x(int i) {} int main() { S s; s.x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-9]]:11: note: default parameter was declared here // CHECK-NEXT: void S::x(int i = 12) {} x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-19]]:8: note: default parameter was declared here // CHECK-NEXT: void x(int i = 12); } |