diff options
author | Tom Stellard <tstellar@redhat.com> | 2018-11-29 02:54:32 +0000 |
---|---|---|
committer | Tom Stellard <tstellar@redhat.com> | 2018-11-29 02:54:32 +0000 |
commit | d0c679795af3e62583b0f0da4a8bd27f48f7ed5e (patch) | |
tree | 1f9f173fd3f6d8534df88a0528469841385eca79 | |
parent | 1c877ca76e6bc3ce458127d1478aff72f7f57c0d (diff) |
Merging r343105:
------------------------------------------------------------------------
r343105 | lebedevri | 2018-09-26 06:08:44 -0700 (Wed, 26 Sep 2018) | 17 lines
[analyzer] scan-build: if --status-bugs is passed, don't forget about the exit status of the actual build
Summary:
This has been bothering me for a while, but only now i have actually looked into this.
I'm using one CI job for static analysis - clang static analyzers as compilers + clang-tidy via cmake.
And i'd like for the build to fail if at least one of those finds issues.
If clang-tidy finds issues, it will fail the build since the warnings-as-errors is set.
If static analyzer finds anything, since --status-bugs is set, it will fail the build.
But if clang-tidy find anything, but static analyzer does not, the build succeeds :/
Reviewers: sylvestre.ledru, alexfh, jroelofs, ygribov, george.karpenkov, krememek
Reviewed By: jroelofs
Subscribers: xazax.hun, szepet, a.sidorin, mikhail.ramalho, Szelethus, cfe-commits
Differential Revision: https://reviews.llvm.org/D52530
------------------------------------------------------------------------
-rwxr-xr-x | clang/tools/scan-build/bin/scan-build | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/tools/scan-build/bin/scan-build b/clang/tools/scan-build/bin/scan-build index c50f900cc45..88420ef94d5 100755 --- a/clang/tools/scan-build/bin/scan-build +++ b/clang/tools/scan-build/bin/scan-build @@ -1192,7 +1192,7 @@ OPTIONS: By default, the exit status of scan-build is the same as the executed build command. Specifying this option causes the exit status of scan-build to be 1 - if it found potential bugs and 0 otherwise. + if it found potential bugs and the exit status of the build itself otherwise. --use-cc [compiler path] --use-cc=[compiler path] @@ -1878,7 +1878,7 @@ if (defined $Options{OutputFormat}) { if ($Options{ExitStatusFoundBugs}) { exit 1 if ($NumBugs > 0); - exit 0; + exit $ExitStatus; } } } |