summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Weber <nicolasweber@gmx.de>2018-04-10 13:14:03 +0000
committerNico Weber <nicolasweber@gmx.de>2018-04-10 13:14:03 +0000
commit41416dc520f92770927be3ef085a367c570e033c (patch)
tree19412570fb24901f0138f50c75eb225809e72978
parent0fc49d26eb9b515a7bceed5ed1a9fe7319d686c1 (diff)
s/LLVM_ON_WIN32/_WIN32/, clang-tools-extra
LLVM_ON_WIN32 is set exactly with MSVC and MinGW (but not Cygwin) in HandleLLVMOptions.cmake, which is where _WIN32 defined too. Just use the default macro instead of a reinvented one. See thread "Replacing LLVM_ON_WIN32 with just _WIN32" on llvm-dev and cfe-dev. No intended behavior change.
-rw-r--r--clang-tools-extra/clangd/ClangdLSPServer.cpp2
-rw-r--r--clang-tools-extra/unittests/clangd/SymbolCollectorTests.cpp4
-rw-r--r--clang-tools-extra/unittests/clangd/TestFS.cpp2
-rw-r--r--clang-tools-extra/unittests/clangd/URITests.cpp4
4 files changed, 6 insertions, 6 deletions
diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp
index 61dbd6689da..8187f7830e3 100644
--- a/clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -38,7 +38,7 @@ public:
"Expect URI body to be an absolute path starting with '/': " + Body,
llvm::inconvertibleErrorCode());
Body = Body.ltrim('/');
-#ifdef LLVM_ON_WIN32
+#ifdef _WIN32
constexpr char TestDir[] = "C:\\clangd-test";
#else
constexpr char TestDir[] = "/clangd-test";
diff --git a/clang-tools-extra/unittests/clangd/SymbolCollectorTests.cpp b/clang-tools-extra/unittests/clangd/SymbolCollectorTests.cpp
index 8333b17ec3d..9e23ca4564b 100644
--- a/clang-tools-extra/unittests/clangd/SymbolCollectorTests.cpp
+++ b/clang-tools-extra/unittests/clangd/SymbolCollectorTests.cpp
@@ -286,7 +286,7 @@ TEST_F(SymbolCollectorTest, SymbolRelativeWithFallback) {
UnorderedElementsAre(AllOf(QName("Foo"), DeclURI(TestHeaderURI))));
}
-#ifndef LLVM_ON_WIN32
+#ifndef _WIN32
TEST_F(SymbolCollectorTest, CustomURIScheme) {
// Use test URI scheme from URITests.cpp
CollectorOpts.URISchemes.insert(CollectorOpts.URISchemes.begin(), "unittest");
@@ -571,7 +571,7 @@ TEST_F(SymbolCollectorTest, IncludeHeaderSameAsFileURI) {
IncludeHeader(TestHeaderURI))));
}
-#ifndef LLVM_ON_WIN32
+#ifndef _WIN32
TEST_F(SymbolCollectorTest, CanonicalSTLHeader) {
CollectorOpts.CollectIncludePath = true;
CanonicalIncludes Includes;
diff --git a/clang-tools-extra/unittests/clangd/TestFS.cpp b/clang-tools-extra/unittests/clangd/TestFS.cpp
index 1b9bb04feb2..2484590e2d2 100644
--- a/clang-tools-extra/unittests/clangd/TestFS.cpp
+++ b/clang-tools-extra/unittests/clangd/TestFS.cpp
@@ -45,7 +45,7 @@ MockCompilationDatabase::getCompileCommand(PathRef File) const {
}
const char *testRoot() {
-#ifdef LLVM_ON_WIN32
+#ifdef _WIN32
return "C:\\clangd-test";
#else
return "/clangd-test";
diff --git a/clang-tools-extra/unittests/clangd/URITests.cpp b/clang-tools-extra/unittests/clangd/URITests.cpp
index 5c2ff244455..4ddc1645afb 100644
--- a/clang-tools-extra/unittests/clangd/URITests.cpp
+++ b/clang-tools-extra/unittests/clangd/URITests.cpp
@@ -93,7 +93,7 @@ std::string resolveOrDie(const URI &U, llvm::StringRef HintPath = "") {
}
TEST(URITest, Create) {
-#ifdef LLVM_ON_WIN32
+#ifdef _WIN32
EXPECT_THAT(createOrDie("c:\\x\\y\\z"), "file:///c%3a/x/y/z");
#else
EXPECT_THAT(createOrDie("/x/y/z"), "file:///x/y/z");
@@ -162,7 +162,7 @@ TEST(URITest, ParseFailed) {
}
TEST(URITest, Resolve) {
-#ifdef LLVM_ON_WIN32
+#ifdef _WIN32
EXPECT_THAT(resolveOrDie(parseOrDie("file:///c%3a/x/y/z")), "c:\\x\\y\\z");
#else
EXPECT_EQ(resolveOrDie(parseOrDie("file:/a/b/c")), "/a/b/c");