summaryrefslogtreecommitdiff
path: root/clang-tools-extra
diff options
context:
space:
mode:
authorSam McCall <sam.mccall@gmail.com>2018-06-05 17:58:12 +0000
committerSam McCall <sam.mccall@gmail.com>2018-06-05 17:58:12 +0000
commitbbfbfc698df9cb7310605a4f6d848a6d24edb4c6 (patch)
tree723790e81483fb14e936e1c4d891c9f7fe647eb6 /clang-tools-extra
parentc85ac5a37e53a376201204a05b943a27953195e7 (diff)
[clangd] Quality fixes (uninit var, missing debug output, pattern decl CCRs).
Diffstat (limited to 'clang-tools-extra')
-rw-r--r--clang-tools-extra/clangd/Quality.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/clang-tools-extra/clangd/Quality.cpp b/clang-tools-extra/clangd/Quality.cpp
index 9ac9955e723..9ec01b27bef 100644
--- a/clang-tools-extra/clangd/Quality.cpp
+++ b/clang-tools-extra/clangd/Quality.cpp
@@ -69,7 +69,7 @@ raw_ostream &operator<<(raw_ostream &OS, const SymbolQualitySignals &S) {
static SymbolRelevanceSignals::AccessibleScope
ComputeScope(const NamedDecl &D) {
- bool InClass;
+ bool InClass = true;
for (const DeclContext *DC = D.getDeclContext(); !DC->isFileContext();
DC = DC->getParent()) {
if (DC->isFunctionOrMethod())
@@ -103,7 +103,7 @@ void SymbolRelevanceSignals::merge(const CodeCompletionResult &SemaCCResult) {
}
// Declarations are scoped, others (like macros) are assumed global.
- if (SemaCCResult.Kind == CodeCompletionResult::RK_Declaration)
+ if (SemaCCResult.Declaration)
Scope = std::min(Scope, ComputeScope(*SemaCCResult.Declaration));
}
@@ -142,6 +142,9 @@ raw_ostream &operator<<(raw_ostream &OS, const SymbolRelevanceSignals &S) {
OS << formatv("=== Symbol relevance: {0}\n", S.evaluate());
OS << formatv("\tName match: {0}\n", S.NameMatch);
OS << formatv("\tForbidden: {0}\n", S.Forbidden);
+ OS << formatv("\tProximity: {0}\n", S.ProximityScore);
+ OS << formatv("\tQuery type: {0}\n", static_cast<int>(S.Query));
+ OS << formatv("\tScope: {0}\n", static_cast<int>(S.Scope));
return OS;
}