summaryrefslogtreecommitdiff
path: root/libcxx
diff options
context:
space:
mode:
authorMarshall Clow <mclow.lists@gmail.com>2019-01-08 02:48:45 +0000
committerMarshall Clow <mclow.lists@gmail.com>2019-01-08 02:48:45 +0000
commit5006fcfc2077c0508967e68dbc2664049190a429 (patch)
tree1fee29cde7852722021d1bd9ddac05d94af59af0 /libcxx
parent7d7b3ea2aab958621ffb87337086b0e735fb26fa (diff)
Set the buffer of an fstream to empty when the underlying file is closed. This 'fixes' PR#38052 - std::fstream still good after closing and updating content.
Diffstat (limited to 'libcxx')
-rw-r--r--libcxx/include/fstream1
-rw-r--r--libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.close.pass.cpp35
2 files changed, 36 insertions, 0 deletions
diff --git a/libcxx/include/fstream b/libcxx/include/fstream
index 332b4747c1a..711e484e2dc 100644
--- a/libcxx/include/fstream
+++ b/libcxx/include/fstream
@@ -702,6 +702,7 @@ basic_filebuf<_CharT, _Traits>::close()
__file_ = 0;
else
__rt = 0;
+ setbuf(0, 0);
}
return __rt;
}
diff --git a/libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.close.pass.cpp b/libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.close.pass.cpp
new file mode 100644
index 00000000000..0f8defcbd97
--- /dev/null
+++ b/libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.close.pass.cpp
@@ -0,0 +1,35 @@
+//===----------------------------------------------------------------------===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+// <fstream>
+
+// template <class charT, class traits = char_traits<charT> >
+// class basic_fstream
+
+// close();
+
+// Inspired by PR#38052 - std::fstream still good after closing and updating content
+
+#include <fstream>
+#include <cassert>
+#include "platform_support.h"
+
+int main()
+{
+ std::string temp = get_temp_file_name();
+
+ std::fstream ofs(temp, std::ios::out | std::ios::trunc);
+ ofs << "Hello, World!\n";
+ assert( ofs.good());
+ ofs.close();
+ assert( ofs.good());
+ ofs << "Hello, World!\n";
+ assert(!ofs.good());
+
+ std::remove(temp.c_str());
+}