diff options
| author | Martin Storsjo <martin@martin.st> | 2017-11-16 19:36:48 +0000 |
|---|---|---|
| committer | Martin Storsjo <martin@martin.st> | 2017-11-16 19:36:48 +0000 |
| commit | 299f4710d019ed094ce950822b96fe000228e578 (patch) | |
| tree | 4c83190ae837866909bb0d4b901cd0747ed5b3be /libunwind | |
| parent | 3c44d28def956f26eb0b677933872d62c6a5c361 (diff) | |
Remove a FIXME about truncated section names
If the linker chose to store the full section name instead of truncating
it, this field doesn't contain a truncated name, but an offset into
the string table of the binary. The string table isn't loaded/mapped
into memory during runtime though, so it's not possible to read the
full section name, unless we try to locate the DLL/EXE on disk that
the HMODULE corresponds to and load that manually.
Due to this, lld now always prefers writing a truncated section name
for sections that will be mapped at runtime, even when debug info is
enabled.
Differential Revision: https://reviews.llvm.org/D39918
Diffstat (limited to 'libunwind')
| -rw-r--r-- | libunwind/src/AddressSpace.hpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libunwind/src/AddressSpace.hpp b/libunwind/src/AddressSpace.hpp index 32428400526..2be16afe365 100644 --- a/libunwind/src/AddressSpace.hpp +++ b/libunwind/src/AddressSpace.hpp @@ -382,8 +382,6 @@ inline bool LocalAddressSpace::findUnwindSections(pint_t targetAddr, found_obj = true; } else if (!strncmp((const char *)pish->Name, ".eh_frame", IMAGE_SIZEOF_SHORT_NAME)) { - // FIXME: This section name actually is truncated, ideally we - // should locate and check the full long name instead. info.dwarf_section = begin; info.dwarf_section_length = pish->Misc.VirtualSize; found_hdr = true; |