summaryrefslogtreecommitdiff
path: root/llvm/include/llvm/Object/Wasm.h
diff options
context:
space:
mode:
authorJF Bastien <jfb@google.com>2018-05-16 21:24:03 +0000
committerJF Bastien <jfb@google.com>2018-05-16 21:24:03 +0000
commit2285824f96652c0475d8143324a6b0d959bc298e (patch)
tree9ac8dc89ed4d9ca9a5579e00735d28a9ed873635 /llvm/include/llvm/Object/Wasm.h
parentb481889dd746ecb9b9aea585a4ddd264488575d1 (diff)
[NFC] WebAssembly build fix
Summary: r332305 added a use of llvm::wasm::toString in llvm::object::WasmSymbol::print, which is in a header file. It also moves toString to BinaryFormat. This has the unintended side-effect that any inclusion of Object/Wasm.h now relies on toString, and needs to required_libraries = BinaryFormat. Thankfully most builds don't fail with this because print just isn't used and gets eliminated, dropping the required dependency in the process. Not all builds are so lucky. Fix this issue by moving print to the corresponding .cpp file. <rdar://problem/40258137> Reviewers: sbc100, ncw, paquette Subscribers: dschuff, jgravelle-google, aheejin, sunfish, llvm-commits Differential Revision: https://reviews.llvm.org/D46977
Diffstat (limited to 'llvm/include/llvm/Object/Wasm.h')
-rw-r--r--llvm/include/llvm/Object/Wasm.h13
1 files changed, 1 insertions, 12 deletions
diff --git a/llvm/include/llvm/Object/Wasm.h b/llvm/include/llvm/Object/Wasm.h
index 146b34af198..c9e630bccb3 100644
--- a/llvm/include/llvm/Object/Wasm.h
+++ b/llvm/include/llvm/Object/Wasm.h
@@ -88,18 +88,7 @@ public:
return Info.Flags & wasm::WASM_SYMBOL_VISIBILITY_MASK;
}
- void print(raw_ostream &Out) const {
- Out << "Name=" << Info.Name
- << ", Kind=" << toString(wasm::WasmSymbolType(Info.Kind))
- << ", Flags=" << Info.Flags;
- if (!isTypeData()) {
- Out << ", ElemIndex=" << Info.ElementIndex;
- } else if (isDefined()) {
- Out << ", Segment=" << Info.DataRef.Segment;
- Out << ", Offset=" << Info.DataRef.Offset;
- Out << ", Size=" << Info.DataRef.Size;
- }
- }
+ void print(raw_ostream &Out) const;
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void dump() const { print(dbgs()); }