diff options
author | Jason Henline <jhen@google.com> | 2016-09-09 23:33:58 +0000 |
---|---|---|
committer | Jason Henline <jhen@google.com> | 2016-09-09 23:33:58 +0000 |
commit | 6d0b75b4715bfb3d6d64df6e0db3f6c8b67ee93d (patch) | |
tree | 61939ed9bc53583412369045fb30a9c3678e90a6 /parallel-libs | |
parent | 64fa3191f390e5b48af5a09953d2c5daab3fd179 (diff) |
[SE] Remove Utils directory
Summary:
There is no purpose in splitting out the Error class from the rest of
the StreamExecutor code. This organization was just a vestige of an old
failed design.
Plus, this change fixes a bug in the build where the utilites library
was not being statically linked in with libstreamexecutor.
Reviewers: jlebar, jprice
Subscribers: beanz, parallel_libs-commits
Differential Revision: https://reviews.llvm.org/D24434
Diffstat (limited to 'parallel-libs')
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/Device.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/DeviceMemory.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/Error.h (renamed from parallel-libs/streamexecutor/include/streamexecutor/Utils/Error.h) | 6 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/Kernel.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/Platform.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/PlatformDevice.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/PlatformManager.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/include/streamexecutor/Stream.h | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/lib/CMakeLists.txt | 6 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/lib/Error.cpp (renamed from parallel-libs/streamexecutor/lib/Utils/Error.cpp) | 2 | ||||
-rw-r--r-- | parallel-libs/streamexecutor/lib/Utils/CMakeLists.txt | 3 |
11 files changed, 12 insertions, 19 deletions
diff --git a/parallel-libs/streamexecutor/include/streamexecutor/Device.h b/parallel-libs/streamexecutor/include/streamexecutor/Device.h index 97741282ff0..3e8c2c892ff 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/Device.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/Device.h @@ -17,9 +17,9 @@ #include <type_traits> +#include "streamexecutor/Error.h" #include "streamexecutor/KernelSpec.h" #include "streamexecutor/PlatformDevice.h" -#include "streamexecutor/Utils/Error.h" namespace streamexecutor { diff --git a/parallel-libs/streamexecutor/include/streamexecutor/DeviceMemory.h b/parallel-libs/streamexecutor/include/streamexecutor/DeviceMemory.h index 1cbeac2b460..21931512b0b 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/DeviceMemory.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/DeviceMemory.h @@ -32,7 +32,7 @@ #include <cassert> #include <cstddef> -#include "streamexecutor/Utils/Error.h" +#include "streamexecutor/Error.h" namespace streamexecutor { diff --git a/parallel-libs/streamexecutor/include/streamexecutor/Utils/Error.h b/parallel-libs/streamexecutor/include/streamexecutor/Error.h index 96eccfa0bcb..b2d1ebb830d 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/Utils/Error.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/Error.h @@ -160,8 +160,8 @@ /// //===----------------------------------------------------------------------===// -#ifndef STREAMEXECUTOR_UTILS_ERROR_H -#define STREAMEXECUTOR_UTILS_ERROR_H +#ifndef STREAMEXECUTOR_ERROR_H +#define STREAMEXECUTOR_ERROR_H #include <cstdio> #include <cstdlib> @@ -212,4 +212,4 @@ void dieIfError(Error &&E); } // namespace streamexecutor -#endif // STREAMEXECUTOR_UTILS_ERROR_H +#endif // STREAMEXECUTOR_ERROR_H diff --git a/parallel-libs/streamexecutor/include/streamexecutor/Kernel.h b/parallel-libs/streamexecutor/include/streamexecutor/Kernel.h index 6ea7c361803..d8cbb8ad26b 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/Kernel.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/Kernel.h @@ -21,8 +21,8 @@ #ifndef STREAMEXECUTOR_KERNEL_H #define STREAMEXECUTOR_KERNEL_H +#include "streamexecutor/Error.h" #include "streamexecutor/KernelSpec.h" -#include "streamexecutor/Utils/Error.h" #include <memory> diff --git a/parallel-libs/streamexecutor/include/streamexecutor/Platform.h b/parallel-libs/streamexecutor/include/streamexecutor/Platform.h index 674a40c0ab1..7b26f4972c8 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/Platform.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/Platform.h @@ -18,7 +18,7 @@ #ifndef STREAMEXECUTOR_PLATFORM_H #define STREAMEXECUTOR_PLATFORM_H -#include "streamexecutor/Utils/Error.h" +#include "streamexecutor/Error.h" namespace streamexecutor { diff --git a/parallel-libs/streamexecutor/include/streamexecutor/PlatformDevice.h b/parallel-libs/streamexecutor/include/streamexecutor/PlatformDevice.h index 6a46876d8bd..6437760203b 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/PlatformDevice.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/PlatformDevice.h @@ -20,10 +20,10 @@ #define STREAMEXECUTOR_PLATFORMDEVICE_H #include "streamexecutor/DeviceMemory.h" +#include "streamexecutor/Error.h" #include "streamexecutor/Kernel.h" #include "streamexecutor/LaunchDimensions.h" #include "streamexecutor/PackedKernelArgumentArray.h" -#include "streamexecutor/Utils/Error.h" namespace streamexecutor { diff --git a/parallel-libs/streamexecutor/include/streamexecutor/PlatformManager.h b/parallel-libs/streamexecutor/include/streamexecutor/PlatformManager.h index c8f68fc1741..7d0de12528d 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/PlatformManager.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/PlatformManager.h @@ -21,8 +21,8 @@ #include <map> +#include "streamexecutor/Error.h" #include "streamexecutor/Platform.h" -#include "streamexecutor/Utils/Error.h" namespace streamexecutor { diff --git a/parallel-libs/streamexecutor/include/streamexecutor/Stream.h b/parallel-libs/streamexecutor/include/streamexecutor/Stream.h index ac57354fd17..704a81538e0 100644 --- a/parallel-libs/streamexecutor/include/streamexecutor/Stream.h +++ b/parallel-libs/streamexecutor/include/streamexecutor/Stream.h @@ -35,11 +35,11 @@ #include <string> #include "streamexecutor/DeviceMemory.h" +#include "streamexecutor/Error.h" #include "streamexecutor/Kernel.h" #include "streamexecutor/LaunchDimensions.h" #include "streamexecutor/PackedKernelArgumentArray.h" #include "streamexecutor/PlatformDevice.h" -#include "streamexecutor/Utils/Error.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/Twine.h" diff --git a/parallel-libs/streamexecutor/lib/CMakeLists.txt b/parallel-libs/streamexecutor/lib/CMakeLists.txt index 11873c42390..be94cbabc46 100644 --- a/parallel-libs/streamexecutor/lib/CMakeLists.txt +++ b/parallel-libs/streamexecutor/lib/CMakeLists.txt @@ -3,12 +3,11 @@ macro(add_se_library name) set_target_properties(${name} PROPERTIES FOLDER "streamexecutor libraries") endmacro(add_se_library) -add_subdirectory(Utils) - add_se_library( streamexecutor Device.cpp DeviceMemory.cpp + Error.cpp Kernel.cpp KernelSpec.cpp PackedKernelArgumentArray.cpp @@ -16,9 +15,6 @@ add_se_library( PlatformDevice.cpp PlatformManager.cpp Stream.cpp - - LINK_LIBS - utils ) install(TARGETS streamexecutor DESTINATION lib) diff --git a/parallel-libs/streamexecutor/lib/Utils/Error.cpp b/parallel-libs/streamexecutor/lib/Error.cpp index 15a9ccbed98..1f9d4a7834d 100644 --- a/parallel-libs/streamexecutor/lib/Utils/Error.cpp +++ b/parallel-libs/streamexecutor/lib/Error.cpp @@ -12,7 +12,7 @@ /// //===----------------------------------------------------------------------===// -#include "streamexecutor/Utils/Error.h" +#include "streamexecutor/Error.h" #include "llvm/ADT/StringRef.h" diff --git a/parallel-libs/streamexecutor/lib/Utils/CMakeLists.txt b/parallel-libs/streamexecutor/lib/Utils/CMakeLists.txt deleted file mode 100644 index 2cbbc3b170f..00000000000 --- a/parallel-libs/streamexecutor/lib/Utils/CMakeLists.txt +++ /dev/null @@ -1,3 +0,0 @@ -add_se_library( - utils - Error.cpp) |