blob: 09108fcca357ead0972c5c52eb412b97ae5e779a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
// RUN: %check_clang_tidy %s performance-move-constructor-init,modernize-pass-by-value %t -- \
// RUN: -config='{CheckOptions: \
// RUN: [{key: modernize-pass-by-value.ValuesOnly, value: 1}]}' \
// RUN: -- -std=c++11 -isystem %S/Inputs/Headers
#include <s.h>
// CHECK-FIXES: #include <utility>
template <class T> struct remove_reference {typedef T type;};
template <class T> struct remove_reference<T&> {typedef T type;};
template <class T> struct remove_reference<T&&> {typedef T type;};
template <typename T>
typename remove_reference<T>::type&& move(T&& arg) {
return static_cast<typename remove_reference<T>::type&&>(arg);
}
struct C {
C() = default;
C(const C&) = default;
};
struct B {
B() {}
B(const B&) {}
B(B &&) {}
};
struct D : B {
D() : B() {}
D(const D &RHS) : B(RHS) {}
// CHECK-NOTES: :[[@LINE+3]]:16: warning: move constructor initializes base class by calling a copy constructor [performance-move-constructor-init]
// CHECK-NOTES: 26:3: note: copy constructor being called
// CHECK-NOTES: 27:3: note: candidate move constructor here
D(D &&RHS) : B(RHS) {}
};
struct E : B {
E() : B() {}
E(const E &RHS) : B(RHS) {}
E(E &&RHS) : B(move(RHS)) {} // ok
};
struct F {
C M;
F(F &&) : M(C()) {} // ok
};
struct G {
G() = default;
G(const G&) = default;
G(G&&) = delete;
};
struct H : G {
H() = default;
H(const H&) = default;
H(H &&RHS) : G(RHS) {} // ok
};
struct I {
I(const I &) = default; // suppresses move constructor creation
};
struct J : I {
J(J &&RHS) : I(RHS) {} // ok
};
struct K {}; // Has implicit copy and move constructors, is trivially copyable
struct L : K {
L(L &&RHS) : K(RHS) {} // ok
};
struct M {
B Mem;
// CHECK-NOTES: :[[@LINE+1]]:16: warning: move constructor initializes class member by calling a copy constructor [performance-move-constructor-init]
M(M &&RHS) : Mem(RHS.Mem) {}
// CHECK-NOTES: 26:3: note: copy constructor being called
// CHECK-NOTES: 27:3: note: candidate move constructor here
};
struct N {
B Mem;
N(N &&RHS) : Mem(move(RHS.Mem)) {}
};
struct O {
O(O&& other) : b(other.b) {} // ok
const B b;
};
struct P {
P(O&& other) : b(other.b) {} // ok
B b;
};
struct Movable {
Movable(Movable &&) = default;
Movable(const Movable &) = default;
Movable &operator=(const Movable &) = default;
~Movable() {}
};
struct TriviallyCopyable {
TriviallyCopyable() = default;
TriviallyCopyable(TriviallyCopyable &&) = default;
TriviallyCopyable(const TriviallyCopyable &) = default;
};
struct Positive {
Positive(Movable M) : M_(M) {}
// CHECK-NOTES: [[@LINE-1]]:12: warning: pass by value and use std::move [modernize-pass-by-value]
// CHECK-FIXES: Positive(Movable M) : M_(std::move(M)) {}
Movable M_;
};
struct NegativeMultipleInitializerReferences {
NegativeMultipleInitializerReferences(Movable M) : M_(M), n_(M) {}
Movable M_;
Movable n_;
};
struct NegativeReferencedInConstructorBody {
NegativeReferencedInConstructorBody(Movable M) : M_(M) { M_ = M; }
Movable M_;
};
struct NegativeParamTriviallyCopyable {
NegativeParamTriviallyCopyable(TriviallyCopyable T) : T_(T) {}
NegativeParamTriviallyCopyable(int I) : I_(I) {}
TriviallyCopyable T_;
int I_;
};
struct NegativeNotPassedByValue {
// This const ref constructor isn't warned about because the ValuesOnly option is set.
NegativeNotPassedByValue(const Movable &M) : M_(M) {}
NegativeNotPassedByValue(const Movable M) : M_(M) {}
NegativeNotPassedByValue(Movable &M) : M_(M) {}
NegativeNotPassedByValue(Movable *M) : M_(*M) {}
NegativeNotPassedByValue(const Movable *M) : M_(*M) {}
Movable M_;
};
struct Immovable {
Immovable(const Immovable &) = default;
Immovable(Immovable &&) = delete;
};
struct NegativeImmovableParameter {
NegativeImmovableParameter(Immovable I) : I_(I) {}
Immovable I_;
};
|
