diff options
author | Michael Hope <michael.hope@linaro.org> | 2012-07-20 15:38:53 +1200 |
---|---|---|
committer | Michael Hope <michael.hope@linaro.org> | 2012-07-20 15:38:53 +1200 |
commit | 2b168bc84a9a642eec678aafaa8aed0df19c620e (patch) | |
tree | afab6f84dc45a045dca0edbf6a910b90b256f20c | |
parent | d03728d366d5ca05a414c3c49b560a693f727e54 (diff) | |
parent | 06b95b8ad5b876368e15b8b1b833fc5348dea744 (diff) |
Backport Carrot's improvements for 64 bit immediate adds in core registers.
2012-07-02 Michael Hope <michael.hope@linaro.org>
Backport from mainline r189102:
gcc/
2012-07-01 Wei Guozhi <carrot@google.com>
PR target/53447
* config/arm/arm-protos.h (const_ok_for_dimode_op): New prototype.
* config/arm/arm.c (const_ok_for_dimode_op): New function.
* config/arm/constraints.md (Dd): New constraint.
* config/arm/predicates.md (arm_adddi_operand): New predicate.
* config/arm/arm.md (adddi3): Extend it to handle constants.
(arm_adddi3): Likewise.
(addsi3_carryin_<optab>): Extend it to handle sbc case.
(addsi3_carryin_alt2_<optab>): Likewise.
* config/arm/neon.md (adddi3_neon): Extend it to handle constants.
gcc/testsuite/
2012-07-01 Wei Guozhi <carrot@google.com>
PR target/53447
* gcc.target/arm/pr53447-1.c: New testcase.
* gcc.target/arm/pr53447-2.c: New testcase.
* gcc.target/arm/pr53447-3.c: New testcase.
* gcc.target/arm/pr53447-4.c: New testcase.
-rw-r--r-- | ChangeLog.linaro | 27 | ||||
-rw-r--r-- | gcc/config/arm/arm-protos.h | 1 | ||||
-rw-r--r-- | gcc/config/arm/arm.c | 22 | ||||
-rw-r--r-- | gcc/config/arm/arm.md | 30 | ||||
-rw-r--r-- | gcc/config/arm/constraints.md | 8 | ||||
-rw-r--r-- | gcc/config/arm/neon.md | 17 | ||||
-rw-r--r-- | gcc/config/arm/predicates.md | 5 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/arm/pr53447-1.c | 8 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/arm/pr53447-2.c | 8 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/arm/pr53447-3.c | 9 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/arm/pr53447-4.c | 9 |
11 files changed, 123 insertions, 21 deletions
diff --git a/ChangeLog.linaro b/ChangeLog.linaro index d227a875d3d..5e9e314b0ed 100644 --- a/ChangeLog.linaro +++ b/ChangeLog.linaro @@ -1,3 +1,30 @@ +2012-07-02 Michael Hope <michael.hope@linaro.org> + + Backport from mainline r189102: + + gcc/ + 2012-07-01 Wei Guozhi <carrot@google.com> + + PR target/53447 + * config/arm/arm-protos.h (const_ok_for_dimode_op): New prototype. + * config/arm/arm.c (const_ok_for_dimode_op): New function. + * config/arm/constraints.md (Dd): New constraint. + * config/arm/predicates.md (arm_adddi_operand): New predicate. + * config/arm/arm.md (adddi3): Extend it to handle constants. + (arm_adddi3): Likewise. + (addsi3_carryin_<optab>): Extend it to handle sbc case. + (addsi3_carryin_alt2_<optab>): Likewise. + * config/arm/neon.md (adddi3_neon): Extend it to handle constants. + + gcc/testsuite/ + 2012-07-01 Wei Guozhi <carrot@google.com> + + PR target/53447 + * gcc.target/arm/pr53447-1.c: New testcase. + * gcc.target/arm/pr53447-2.c: New testcase. + * gcc.target/arm/pr53447-3.c: New testcase. + * gcc.target/arm/pr53447-4.c: New testcase. + 2012-07-05 Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org> gcc/ diff --git a/gcc/config/arm/arm-protos.h b/gcc/config/arm/arm-protos.h index 055ad38f060..2a880923daf 100644 --- a/gcc/config/arm/arm-protos.h +++ b/gcc/config/arm/arm-protos.h @@ -49,6 +49,7 @@ extern int arm_hard_regno_mode_ok (unsigned int, enum machine_mode); extern bool arm_modes_tieable_p (enum machine_mode, enum machine_mode); extern int const_ok_for_arm (HOST_WIDE_INT); extern int const_ok_for_op (HOST_WIDE_INT, enum rtx_code); +extern int const_ok_for_dimode_op (HOST_WIDE_INT, enum rtx_code); extern int arm_split_constant (RTX_CODE, enum machine_mode, rtx, HOST_WIDE_INT, rtx, rtx, int); extern RTX_CODE arm_canonicalize_comparison (RTX_CODE, rtx *, rtx *); diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 6c0304f16f6..a8722f93224 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -2493,6 +2493,28 @@ const_ok_for_op (HOST_WIDE_INT i, enum rtx_code code) } } +/* Return true if I is a valid di mode constant for the operation CODE. */ +int +const_ok_for_dimode_op (HOST_WIDE_INT i, enum rtx_code code) +{ + HOST_WIDE_INT hi_val = (i >> 32) & 0xFFFFFFFF; + HOST_WIDE_INT lo_val = i & 0xFFFFFFFF; + rtx hi = GEN_INT (hi_val); + rtx lo = GEN_INT (lo_val); + + if (TARGET_THUMB1) + return 0; + + switch (code) + { + case PLUS: + return arm_not_operand (hi, SImode) && arm_add_operand (lo, SImode); + + default: + return 0; + } +} + /* Emit a sequence of insns to handle a large constant. CODE is the code of the operation required, it can be any of SET, PLUS, IOR, AND, XOR, MINUS; diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md index 8484b8305bd..c00d534cb08 100644 --- a/gcc/config/arm/arm.md +++ b/gcc/config/arm/arm.md @@ -573,7 +573,7 @@ [(parallel [(set (match_operand:DI 0 "s_register_operand" "") (plus:DI (match_operand:DI 1 "s_register_operand" "") - (match_operand:DI 2 "s_register_operand" ""))) + (match_operand:DI 2 "arm_adddi_operand" ""))) (clobber (reg:CC CC_REGNUM))])] "TARGET_EITHER" " @@ -609,9 +609,9 @@ ) (define_insn_and_split "*arm_adddi3" - [(set (match_operand:DI 0 "s_register_operand" "=&r,&r") - (plus:DI (match_operand:DI 1 "s_register_operand" "%0, 0") - (match_operand:DI 2 "s_register_operand" "r, 0"))) + [(set (match_operand:DI 0 "s_register_operand" "=&r,&r,&r,&r,&r") + (plus:DI (match_operand:DI 1 "s_register_operand" "%0, 0, r, 0, r") + (match_operand:DI 2 "arm_adddi_operand" "r, 0, r, Dd, Dd"))) (clobber (reg:CC CC_REGNUM))] "TARGET_32BIT && !(TARGET_HARD_FLOAT && TARGET_MAVERICK) && !TARGET_NEON" "#" @@ -629,7 +629,7 @@ operands[0] = gen_lowpart (SImode, operands[0]); operands[4] = gen_highpart (SImode, operands[1]); operands[1] = gen_lowpart (SImode, operands[1]); - operands[5] = gen_highpart (SImode, operands[2]); + operands[5] = gen_highpart_mode (SImode, DImode, operands[2]); operands[2] = gen_lowpart (SImode, operands[2]); }" [(set_attr "conds" "clob") @@ -979,22 +979,26 @@ ) (define_insn "*addsi3_carryin_<optab>" - [(set (match_operand:SI 0 "s_register_operand" "=r") - (plus:SI (plus:SI (match_operand:SI 1 "s_register_operand" "%r") - (match_operand:SI 2 "arm_rhs_operand" "rI")) + [(set (match_operand:SI 0 "s_register_operand" "=r,r") + (plus:SI (plus:SI (match_operand:SI 1 "s_register_operand" "%r,r") + (match_operand:SI 2 "arm_not_operand" "rI,K")) (LTUGEU:SI (reg:<cnb> CC_REGNUM) (const_int 0))))] "TARGET_32BIT" - "adc%?\\t%0, %1, %2" + "@ + adc%?\\t%0, %1, %2 + sbc%?\\t%0, %1, #%B2" [(set_attr "conds" "use")] ) (define_insn "*addsi3_carryin_alt2_<optab>" - [(set (match_operand:SI 0 "s_register_operand" "=r") + [(set (match_operand:SI 0 "s_register_operand" "=r,r") (plus:SI (plus:SI (LTUGEU:SI (reg:<cnb> CC_REGNUM) (const_int 0)) - (match_operand:SI 1 "s_register_operand" "%r")) - (match_operand:SI 2 "arm_rhs_operand" "rI")))] + (match_operand:SI 1 "s_register_operand" "%r,r")) + (match_operand:SI 2 "arm_rhs_operand" "rI,K")))] "TARGET_32BIT" - "adc%?\\t%0, %1, %2" + "@ + adc%?\\t%0, %1, %2 + sbc%?\\t%0, %1, #%B2" [(set_attr "conds" "use")] ) diff --git a/gcc/config/arm/constraints.md b/gcc/config/arm/constraints.md index d21b5683529..5494c71c845 100644 --- a/gcc/config/arm/constraints.md +++ b/gcc/config/arm/constraints.md @@ -29,7 +29,7 @@ ;; in Thumb-1 state: I, J, K, L, M, N, O ;; The following multi-letter normal constraints have been used: -;; in ARM/Thumb-2 state: Da, Db, Dc, Dn, Dl, DL, Dv, Dy, Di, Dt, Dz +;; in ARM/Thumb-2 state: Da, Db, Dc, Dd, Dn, Dl, DL, Dv, Dy, Di, Dt, Dz ;; in Thumb-1 state: Pa, Pb, Pc, Pd ;; in Thumb-2 state: Pj, PJ, Ps, Pt, Pu, Pv, Pw, Px, Py @@ -246,6 +246,12 @@ (match_test "TARGET_32BIT && arm_const_double_inline_cost (op) == 4 && !(optimize_size || arm_ld_sched)"))) +(define_constraint "Dd" + "@internal + In ARM/Thumb-2 state a const_int that can be used by insn adddi." + (and (match_code "const_int") + (match_test "TARGET_32BIT && const_ok_for_dimode_op (ival, PLUS)"))) + (define_constraint "Di" "@internal In ARM/Thumb-2 state a const_int or const_double where both the high diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 4568dead2f1..c5cc5a7fa9f 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -588,9 +588,9 @@ ) (define_insn "adddi3_neon" - [(set (match_operand:DI 0 "s_register_operand" "=w,?&r,?&r,?w") - (plus:DI (match_operand:DI 1 "s_register_operand" "%w,0,0,w") - (match_operand:DI 2 "s_register_operand" "w,r,0,w"))) + [(set (match_operand:DI 0 "s_register_operand" "=w,?&r,?&r,?w,?&r,?&r,?&r") + (plus:DI (match_operand:DI 1 "s_register_operand" "%w,0,0,w,r,0,r") + (match_operand:DI 2 "arm_adddi_operand" "w,r,0,w,r,Dd,Dd"))) (clobber (reg:CC CC_REGNUM))] "TARGET_NEON" { @@ -600,13 +600,16 @@ case 3: return "vadd.i64\t%P0, %P1, %P2"; case 1: return "#"; case 2: return "#"; + case 4: return "#"; + case 5: return "#"; + case 6: return "#"; default: gcc_unreachable (); } } - [(set_attr "neon_type" "neon_int_1,*,*,neon_int_1") - (set_attr "conds" "*,clob,clob,*") - (set_attr "length" "*,8,8,*") - (set_attr "arch" "nota8,*,*,onlya8")] + [(set_attr "neon_type" "neon_int_1,*,*,neon_int_1,*,*,*") + (set_attr "conds" "*,clob,clob,*,clob,clob,clob") + (set_attr "length" "*,8,8,*,8,8,8") + (set_attr "arch" "nota8,*,*,onlya8,*,*,*")] ) (define_insn "*sub<mode>3_neon" diff --git a/gcc/config/arm/predicates.md b/gcc/config/arm/predicates.md index 2ccfb349c51..41fa519883b 100644 --- a/gcc/config/arm/predicates.md +++ b/gcc/config/arm/predicates.md @@ -154,6 +154,11 @@ (ior (match_operand 0 "arm_rhs_operand") (match_operand 0 "arm_neg_immediate_operand"))) +(define_predicate "arm_adddi_operand" + (ior (match_operand 0 "s_register_operand") + (and (match_code "const_int") + (match_test "const_ok_for_dimode_op (INTVAL (op), PLUS)")))) + (define_predicate "arm_addimm_operand" (ior (match_operand 0 "arm_immediate_operand") (match_operand 0 "arm_neg_immediate_operand"))) diff --git a/gcc/testsuite/gcc.target/arm/pr53447-1.c b/gcc/testsuite/gcc.target/arm/pr53447-1.c new file mode 100644 index 00000000000..dc094180c85 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr53447-1.c @@ -0,0 +1,8 @@ +/* { dg-options "-O2" } */ +/* { dg-require-effective-target arm32 } */ +/* { dg-final { scan-assembler-not "mov" } } */ + +void t0p(long long * p) +{ + *p += 0x100000001; +} diff --git a/gcc/testsuite/gcc.target/arm/pr53447-2.c b/gcc/testsuite/gcc.target/arm/pr53447-2.c new file mode 100644 index 00000000000..9a2b0315c1a --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr53447-2.c @@ -0,0 +1,8 @@ +/* { dg-options "-O2" } */ +/* { dg-require-effective-target arm32 } */ +/* { dg-final { scan-assembler-not "mov" } } */ + +void t0p(long long * p) +{ + *p -= 0x100000008; +} diff --git a/gcc/testsuite/gcc.target/arm/pr53447-3.c b/gcc/testsuite/gcc.target/arm/pr53447-3.c new file mode 100644 index 00000000000..8e48f119b74 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr53447-3.c @@ -0,0 +1,9 @@ +/* { dg-options "-O2" } */ +/* { dg-require-effective-target arm32 } */ +/* { dg-final { scan-assembler-not "mov" } } */ + + +void t0p(long long * p) +{ + *p +=0x1fffffff8; +} diff --git a/gcc/testsuite/gcc.target/arm/pr53447-4.c b/gcc/testsuite/gcc.target/arm/pr53447-4.c new file mode 100644 index 00000000000..22acb97270e --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr53447-4.c @@ -0,0 +1,9 @@ +/* { dg-options "-O2" } */ +/* { dg-require-effective-target arm32 } */ +/* { dg-final { scan-assembler-not "mov" } } */ + + +void t0p(long long * p) +{ + *p -=0x1fffffff8; +} |