aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Thomas <pault@gcc.gnu.org>2024-04-09 15:23:46 +0100
committerPaul Thomas <pault@gcc.gnu.org>2024-05-08 09:06:27 +0100
commit102d52967bde164d6b99037465688b62d57ae560 (patch)
treeb9416f271ca81a1113f4d486f9c9066ebeadb419
parent9fd6f7e912415f426382099d6aa182fd2b8ebb82 (diff)
Fortran: Fix ICE in gfc_trans_pointer_assignment [PR113956]
2024-04-09 Paul Thomas <pault@gcc.gnu.org> gcc/fortran PR fortran/113956 * trans-expr.cc (gfc_trans_pointer_assignment): Remove assert causing the ICE since it was unnecesary. gcc/testsuite/ PR fortran/113956 * gfortran.dg/pr113956.f90: New test. (cherry picked from commit 88aea122a7ee639230bf17a9eda4bf8a5eb7e282)
-rw-r--r--gcc/fortran/trans-expr.cc9
-rw-r--r--gcc/testsuite/gfortran.dg/pr113956.f9021
2 files changed, 24 insertions, 6 deletions
diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc
index c7ec591e279..5c5fabf5f5a 100644
--- a/gcc/fortran/trans-expr.cc
+++ b/gcc/fortran/trans-expr.cc
@@ -10257,12 +10257,9 @@ gfc_trans_pointer_assignment (gfc_expr * expr1, gfc_expr * expr2)
{
gfc_symbol *psym = expr1->symtree->n.sym;
tmp = NULL_TREE;
- if (psym->ts.type == BT_CHARACTER)
- {
- gcc_assert (psym->ts.u.cl->backend_decl
- && VAR_P (psym->ts.u.cl->backend_decl));
- tmp = psym->ts.u.cl->backend_decl;
- }
+ if (psym->ts.type == BT_CHARACTER
+ && psym->ts.u.cl->backend_decl)
+ tmp = psym->ts.u.cl->backend_decl;
else if (expr1->ts.u.cl->backend_decl
&& VAR_P (expr1->ts.u.cl->backend_decl))
tmp = expr1->ts.u.cl->backend_decl;
diff --git a/gcc/testsuite/gfortran.dg/pr113956.f90 b/gcc/testsuite/gfortran.dg/pr113956.f90
new file mode 100644
index 00000000000..229e891f847
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr113956.f90
@@ -0,0 +1,21 @@
+! { dg-do run }
+! Test the fix for PR113956
+! Contributed by David Binderman <dcb314@hotmail.com>
+module m
+contains
+ subroutine test_array_char(p, x)
+ character(*), target :: x(:)
+ character(:), pointer :: p(:)
+ p => x ! ICE
+ end subroutine
+end module
+
+ use m
+ character(:), allocatable, target :: chr(:)
+ character(:), pointer :: p(:)
+ chr = ["ab","cd"]
+ call test_array_char (p, chr)
+ if (loc (chr) .ne. loc (p)) stop 1
+ if (len (p) .ne. 2) stop 2
+ if (any (p .ne. chr)) stop 3
+end