diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2016-05-20 21:09:59 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2016-05-20 21:09:59 +0000 |
commit | 18fcf48fc34ff60432bcb78296796f68287a6410 (patch) | |
tree | a388efe7d075f6297d88748efb6febe232627c01 | |
parent | 63cfb6621a0c758e37ee97a6d8093e28a575b106 (diff) |
Document some constants. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@270274 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | ELF/Target.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/ELF/Target.cpp b/ELF/Target.cpp index 8bbdfd28f..071f442fe 100644 --- a/ELF/Target.cpp +++ b/ELF/Target.cpp @@ -601,6 +601,8 @@ void X86_64TargetInfo::relaxTlsGdToLe(uint8_t *Loc, uint32_t Type, 0x48, 0x8d, 0x80, 0x00, 0x00, 0x00, 0x00 // lea x@tpoff,%rax }; memcpy(Loc - 4, Inst, sizeof(Inst)); + // The original code used a pc relative relocation and so we have to + // compensate for the -4 in had in the addend. relocateOne(Loc + 8, R_X86_64_TPOFF32, Val + 4); } @@ -620,6 +622,8 @@ void X86_64TargetInfo::relaxTlsGdToIe(uint8_t *Loc, uint32_t Type, 0x48, 0x03, 0x05, 0x00, 0x00, 0x00, 0x00 // addq x@tpoff,%rax }; memcpy(Loc - 4, Inst, sizeof(Inst)); + // Both code sequences are PC relatives, but since we are moving the constant + // forward by 8 bytes we have to subtract the value by 8. relocateOne(Loc + 8, R_X86_64_PC32, Val - 8); } @@ -653,6 +657,8 @@ void X86_64TargetInfo::relaxTlsIeToLe(uint8_t *Loc, uint32_t Type, if (*Prefix == 0x4c) *Prefix = (IsMov || RspAdd) ? 0x49 : 0x4d; *RegSlot = (IsMov || RspAdd) ? (0xc0 | Reg) : (0x80 | Reg | (Reg << 3)); + // The original code used a pc relative relocation and so we have to + // compensate for the -4 in had in the addend. relocateOne(Loc, R_X86_64_TPOFF32, Val + 4); } |