aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTao Ma <boyu.mt@taobao.com>2012-09-20 11:35:38 -0400
committerTheodore Ts'o <tytso@mit.edu>2012-09-20 11:35:38 -0400
commitbef53b01faeb791e27605cba1a71ba21364cb23e (patch)
tree0d4b909ffb3fc1169cad66dd2e918fab78bb945b
parent00d4e7362ed01987183e9528295de3213031309c (diff)
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
The update_backups() function is used to backup all the metadata blocks, so we should not take it for granted that 'data' is pointed to a super block and use ext4_superblock_csum_set to calculate the checksum there. In case where the data is a group descriptor block, it will corrupt the last group descriptor, and then e2fsck will complain about it it. As all the metadata checksums should already be OK when we do the backup, remove the wrong ext4_superblock_csum_set and it should be just fine. Reported-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Tao Ma <boyu.mt@taobao.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: stable@vger.kernel.org
-rw-r--r--fs/ext4/resize.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index ee985ca0510..9f821ce3980 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1049,8 +1049,6 @@ static void update_backups(struct super_block *sb, int blk_off, char *data,
goto exit_err;
}
- ext4_superblock_csum_set(sb, (struct ext4_super_block *)data);
-
if (meta_bg == 0) {
group = ext4_list_backups(sb, &three, &five, &seven);
last = sbi->s_groups_count;