aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBalazs Peter Odor <balazs@obiserver.hu>2013-06-22 19:24:43 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2013-06-24 11:32:40 +0200
commit5aed93875cd88502f04a0d4517b8a2d89a849773 (patch)
treefefcfe476ae59a4bec926e121eabbf34eb828017
parent142dcdd3c25fc7a3866bb06980e8f93a2ed7e050 (diff)
netfilter: nf_nat_sip: fix mangling
In (b20ab9c netfilter: nf_ct_helper: better logging for dropped packets) there were some missing brackets around the logging information, thus always returning drop. Closes https://bugzilla.kernel.org/show_bug.cgi?id=60061 Signed-off-by: Balazs Peter Odor <balazs@obiserver.hu> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--net/netfilter/nf_nat_sip.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c
index 96ccdf78a29..dac11f73868 100644
--- a/net/netfilter/nf_nat_sip.c
+++ b/net/netfilter/nf_nat_sip.c
@@ -230,9 +230,10 @@ static unsigned int nf_nat_sip(struct sk_buff *skb, unsigned int protoff,
&ct->tuplehash[!dir].tuple.src.u3,
false);
if (!mangle_packet(skb, protoff, dataoff, dptr, datalen,
- poff, plen, buffer, buflen))
+ poff, plen, buffer, buflen)) {
nf_ct_helper_log(skb, ct, "cannot mangle received");
return NF_DROP;
+ }
}
/* The rport= parameter (RFC 3581) contains the port number