diff options
| author | Erik Faye-Lund <kusmabite@gmail.com> | 2013-10-04 20:18:33 +0000 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2013-10-31 09:20:04 +0100 |
| commit | a9ff999538ab2bf6d3b1ed8ab5a016bfc6fe2cd1 (patch) | |
| tree | 801777608998d0a63d02d9ade96248fbbc7ffe22 /drivers/gpu/host1x | |
| parent | f28c38ae866af00140e8139726ed21de2f4b916b (diff) | |
gpu: host1x: check relocs after all gathers are consumed
The num_relocs count are passed to the kernel per job, not per gather.
For multi-gather jobs, we would previously fail if there were relocs in
other gathers aside from the first one.
Fix this by simply moving the check until all gathers have been
consumed.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Reviewed-by: Arto Merilainen <amerilainen@nvidia.com>
Acked-By: Terje Bergstrom <tbergstrom@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu/host1x')
| -rw-r--r-- | drivers/gpu/host1x/job.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index c4e1050f225..c9ddff8c76c 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -436,10 +436,6 @@ static int validate(struct host1x_firewall *fw, struct host1x_job_gather *g) } } - /* No relocs should remain at this point */ - if (fw->num_relocs) - err = -EINVAL; - out: return err; } @@ -493,6 +489,10 @@ static inline int copy_gathers(struct host1x_job *job, struct device *dev) offset += g->words * sizeof(u32); } + /* No relocs should remain at this point */ + if (fw.num_relocs) + return -EINVAL; + return 0; } |