aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/media
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2013-03-15 16:35:28 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-03-25 08:50:22 -0300
commit69996873478d75381d14abbc9e768cc38d82e94b (patch)
tree5e45ea3bf001bd492bc4b0d75d574a78c49cc2dc /drivers/staging/media
parent15513c12e3c5f5e7c683865b3e019cf90babab8f (diff)
[media] solo6x10: disable the 'priv' abuse
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/staging/media')
-rw-r--r--drivers/staging/media/solo6x10/v4l2-enc.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/staging/media/solo6x10/v4l2-enc.c b/drivers/staging/media/solo6x10/v4l2-enc.c
index 4fbfb351d37..0efb6237f68 100644
--- a/drivers/staging/media/solo6x10/v4l2-enc.c
+++ b/drivers/staging/media/solo6x10/v4l2-enc.c
@@ -860,8 +860,16 @@ static int solo_enc_set_fmt_cap(struct file *file, void *priv,
/* This does not change the encoder at all */
solo_enc->fmt = pix->pixelformat;
+ /*
+ * More information is needed about these 'extended' types. As far
+ * as I can tell these are basically additional video streams with
+ * different MPEG encoding attributes that can run in parallel with
+ * the main stream. If so, then this should be implemented as a
+ * second video node. Abusing priv like this is certainly not the
+ * right approach.
if (pix->priv)
solo_enc->type = SOLO_ENC_TYPE_EXT;
+ */
return 0;
}