aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk@kernel.org>2018-05-03 23:26:02 -0700
committerJaegeuk Kim <jaegeuk@google.com>2018-05-07 17:04:57 -0700
commit2ae4606507f1804b19b369f757a83c324f4246d2 (patch)
tree85575a6cf5d7894cc4390cfeb34d27e463ba5617
parent99e5f1a4b96d2b236b565965143d37c5b3a26838 (diff)
UPSTREAM: f2fs: avoid fsync() failure caused by EAGAIN in writepage()ASB-2018-06-05_4.14ASB-2018-05-05_4.14
pageout() in MM traslates EAGAIN, so calls handle_write_error() -> mapping_set_error() -> set_bit(AS_EIO, ...). file_write_and_wait_range() will see EIO error, which is critical to return value of fsync() followed by atomic_write failure to user. Change-Id: Ifdd5e09defcf0705901ff7f23001d68a811da3af Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> (cherry picked from commit 1ccd6c4ff9ccd74bb87903067618815d326af242)
-rw-r--r--fs/f2fs/data.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 1afce941a9df..c9db73e498a6 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1905,7 +1905,13 @@ out:
redirty_out:
redirty_page_for_writepage(wbc, page);
- if (!err)
+ /*
+ * pageout() in MM traslates EAGAIN, so calls handle_write_error()
+ * -> mapping_set_error() -> set_bit(AS_EIO, ...).
+ * file_write_and_wait_range() will see EIO error, which is critical
+ * to return value of fsync() followed by atomic_write failure to user.
+ */
+ if (!err || wbc->for_reclaim)
return AOP_WRITEPAGE_ACTIVATE;
unlock_page(page);
return err;