aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWei Wang <wvw@google.com>2018-06-11 22:58:13 -0700
committerWei Wang <wvw@google.com>2018-06-12 16:01:54 -0700
commita765425526fe01a8649cea4ce0ae706fa8e8a227 (patch)
tree7023bbacb029e4896739384d1f10880ebae152ab
parent4c57f62a5a0ea826cd0c1ee08bbe8370f1e90fb3 (diff)
scsi: ufs: call single_release to avoid memory leakandroid-p-preview-5_r0.1android-9.0.0_r0.4android-9.0.0_r0.1
Bug: 110044919 Test: Build Change-Id: I9fa83b84cf52a54c24405f2416f8747a20901d3f Signed-off-by: Wei Wang <wvw@google.com>
-rw-r--r--drivers/scsi/ufs/ufs-debugfs.c12
-rw-r--r--drivers/scsi/ufs/ufs-qcom-debugfs.c3
-rw-r--r--drivers/scsi/ufs/ufs_test.c1
3 files changed, 15 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufs-debugfs.c b/drivers/scsi/ufs/ufs-debugfs.c
index e5d9077e7371..bf806ee99a02 100644
--- a/drivers/scsi/ufs/ufs-debugfs.c
+++ b/drivers/scsi/ufs/ufs-debugfs.c
@@ -355,6 +355,7 @@ static const struct file_operations ufsdbg_err_inj_scenario_ops = {
.open = ufsdbg_err_inj_scenario_open,
.read = seq_read,
.write = ufsdbg_err_inj_scenario_write,
+ .release = single_release,
};
static int ufsdbg_err_inj_stats_read(struct seq_file *file, void *data)
@@ -396,6 +397,7 @@ static const struct file_operations ufsdbg_err_inj_stats_ops = {
.open = ufsdbg_err_inj_stats_open,
.read = seq_read,
.write = ufsdbg_err_inj_stats_write,
+ .release = single_release,
};
static void ufsdbg_setup_fault_injection(struct ufs_hba *hba)
@@ -580,6 +582,7 @@ static const struct file_operations ufsdbg_tag_stats_fops = {
.open = ufsdbg_tag_stats_open,
.read = seq_read,
.write = ufsdbg_tag_stats_write,
+ .release = single_release,
};
static int ufsdbg_query_stats_show(struct seq_file *file, void *data)
@@ -651,6 +654,7 @@ static const struct file_operations ufsdbg_query_stats_fops = {
.open = ufsdbg_query_stats_open,
.read = seq_read,
.write = ufsdbg_query_stats_write,
+ .release = single_release,
};
static int ufsdbg_err_stats_show(struct seq_file *file, void *data)
@@ -755,6 +759,7 @@ static const struct file_operations ufsdbg_err_stats_fops = {
.open = ufsdbg_err_stats_open,
.read = seq_read,
.write = ufsdbg_err_stats_write,
+ .release = single_release,
};
static int ufshcd_init_statistics(struct ufs_hba *hba)
@@ -834,6 +839,7 @@ static int ufsdbg_host_regs_open(struct inode *inode, struct file *file)
static const struct file_operations ufsdbg_host_regs_fops = {
.open = ufsdbg_host_regs_open,
.read = seq_read,
+ .release = single_release,
};
static int ufsdbg_dump_device_desc_show(struct seq_file *file, void *data)
@@ -950,6 +956,7 @@ static int ufsdbg_show_hba_open(struct inode *inode, struct file *file)
static const struct file_operations ufsdbg_show_hba_fops = {
.open = ufsdbg_show_hba_open,
.read = seq_read,
+ .release = single_release,
};
static int ufsdbg_dump_device_desc_open(struct inode *inode, struct file *file)
@@ -961,6 +968,7 @@ static int ufsdbg_dump_device_desc_open(struct inode *inode, struct file *file)
static const struct file_operations ufsdbg_dump_device_desc = {
.open = ufsdbg_dump_device_desc_open,
.read = seq_read,
+ .release = single_release,
};
static int ufsdbg_power_mode_show(struct seq_file *file, void *data)
@@ -1199,6 +1207,7 @@ static const struct file_operations ufsdbg_power_mode_desc = {
.open = ufsdbg_power_mode_open,
.read = seq_read,
.write = ufsdbg_power_mode_write,
+ .release = single_release,
};
static int ufsdbg_dme_read(void *data, u64 *attr_val, bool peer)
@@ -1378,9 +1387,9 @@ static const struct file_operations ufsdbg_req_stats_desc = {
.open = ufsdbg_req_stats_open,
.read = seq_read,
.write = ufsdbg_req_stats_write,
+ .release = single_release,
};
-
static int ufsdbg_reset_controller_show(struct seq_file *file, void *data)
{
seq_puts(file, "echo 1 > /sys/kernel/debug/.../reset_controller\n");
@@ -1420,6 +1429,7 @@ static const struct file_operations ufsdbg_reset_controller = {
.open = ufsdbg_reset_controller_open,
.read = seq_read,
.write = ufsdbg_reset_controller_write,
+ .release = single_release,
};
void ufsdbg_add_debugfs(struct ufs_hba *hba)
diff --git a/drivers/scsi/ufs/ufs-qcom-debugfs.c b/drivers/scsi/ufs/ufs-qcom-debugfs.c
index 8532439c392d..72017681bba7 100644
--- a/drivers/scsi/ufs/ufs-qcom-debugfs.c
+++ b/drivers/scsi/ufs/ufs-qcom-debugfs.c
@@ -163,6 +163,7 @@ static const struct file_operations ufs_qcom_dbg_testbus_cfg_desc = {
.open = ufs_qcom_dbg_testbus_cfg_open,
.read = seq_read,
.write = ufs_qcom_dbg_testbus_cfg_write,
+ .release = single_release,
};
static int ufs_qcom_dbg_testbus_bus_read(void *data, u64 *attr_val)
@@ -217,6 +218,7 @@ static int ufs_qcom_dbg_dbg_regs_open(struct inode *inode,
static const struct file_operations ufs_qcom_dbg_dbg_regs_desc = {
.open = ufs_qcom_dbg_dbg_regs_open,
.read = seq_read,
+ .release = single_release,
};
static int ufs_qcom_dbg_pm_qos_show(struct seq_file *file, void *data)
@@ -250,6 +252,7 @@ static int ufs_qcom_dbg_pm_qos_open(struct inode *inode,
static const struct file_operations ufs_qcom_dbg_pm_qos_desc = {
.open = ufs_qcom_dbg_pm_qos_open,
.read = seq_read,
+ .release = single_release,
};
void ufs_qcom_dbg_add_debugfs(struct ufs_hba *hba, struct dentry *root)
diff --git a/drivers/scsi/ufs/ufs_test.c b/drivers/scsi/ufs/ufs_test.c
index 8953722e8dad..01dc91254fb7 100644
--- a/drivers/scsi/ufs/ufs_test.c
+++ b/drivers/scsi/ufs/ufs_test.c
@@ -78,6 +78,7 @@ static const struct file_operations ufs_test_ ## test_name ## _ops = { \
.open = ufs_test_ ## test_name ## _open, \
.read = seq_read, \
.write = ufs_test_ ## test_name ## _write, \
+ .release = single_release, \
};
#define add_test(utd, test_name, upper_case_name) \