diff options
| author | Axel Lin <axel.lin@ingics.com> | 2021-06-03 17:49:44 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-06-03 19:35:48 +0100 |
| commit | cb2381cbecb81a8893b2d1e1af29bc2e5531df27 (patch) | |
| tree | 73645a2e18cdf15e96684a7a878d195b18918296 | |
| parent | 50bec7fb4cb1bcf9d387046b6dec7186590791ec (diff) | |
regulator: rt4801: Fix NULL pointer dereference if priv->enable_gpios is NULLregulator-fix-v5.13-rc4
devm_gpiod_get_array_optional may return NULL if no GPIO was assigned.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210603094944.1114156-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/rt4801-regulator.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/regulator/rt4801-regulator.c b/drivers/regulator/rt4801-regulator.c index 2055a9cb13ba..7a87788d3f09 100644 --- a/drivers/regulator/rt4801-regulator.c +++ b/drivers/regulator/rt4801-regulator.c @@ -66,7 +66,7 @@ static int rt4801_enable(struct regulator_dev *rdev) struct gpio_descs *gpios = priv->enable_gpios; int id = rdev_get_id(rdev), ret; - if (gpios->ndescs <= id) { + if (!gpios || gpios->ndescs <= id) { dev_warn(&rdev->dev, "no dedicated gpio can control\n"); goto bypass_gpio; } @@ -88,7 +88,7 @@ static int rt4801_disable(struct regulator_dev *rdev) struct gpio_descs *gpios = priv->enable_gpios; int id = rdev_get_id(rdev); - if (gpios->ndescs <= id) { + if (!gpios || gpios->ndescs <= id) { dev_warn(&rdev->dev, "no dedicated gpio can control\n"); goto bypass_gpio; } |