From 18fadd6abd5aeb2ddd6c20eb6a6045e377bb9f94 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Mon, 18 Feb 2019 11:23:16 +0800 Subject: gpio: tqmx86: Set proper output level for direction_output For output-only gpios, direction_output should set proper output level. Signed-off-by: Axel Lin Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") Reviewed-by: Andrew Lunn Signed-off-by: Linus Walleij --- drivers/gpio/gpio-tqmx86.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index 33dbe483f92f..d5880db7f9d4 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -93,8 +93,9 @@ static int tqmx86_gpio_direction_output(struct gpio_chip *chip, /* Direction cannot be changed, validate is an output */ if (BIT(offset) & TQMX86_DIR_INPUT_MASK) return -EINVAL; - else - return 0; + + tqmx86_gpio_set(chip, offset, value); + return 0; } static int tqmx86_gpio_get_direction(struct gpio_chip *chip, -- cgit v1.2.3