aboutsummaryrefslogtreecommitdiff
path: root/iothread.c
diff options
context:
space:
mode:
authorStefano Garzarella <sgarzare@redhat.com>2021-07-27 16:59:36 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2021-10-07 15:29:50 +0100
commit1cc7eada97914f090125e588497986f6f7900514 (patch)
treea1ffac217f3694318a33b0cd0880cf460980e172 /iothread.c
parentf0ed36a64f1750a0ebc5d2a5437f4740985461d7 (diff)
iothread: use IOThreadParamInfo in iothread_[set|get]_param()
Commit 0445409d74 ("iothread: generalize iothread_set_param/iothread_get_param") moved common code to set and get IOThread parameters in two new functions. These functions are called inside callbacks, so we don't need to use an opaque pointer. Let's replace `void *opaque` parameter with `IOThreadParamInfo *info`. Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20210727145936.147032-3-sgarzare@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'iothread.c')
-rw-r--r--iothread.c18
1 files changed, 10 insertions, 8 deletions
diff --git a/iothread.c b/iothread.c
index a73e560ba0..0f98af0f2a 100644
--- a/iothread.c
+++ b/iothread.c
@@ -231,20 +231,18 @@ static IOThreadParamInfo aio_max_batch_info = {
};
static void iothread_get_param(Object *obj, Visitor *v,
- const char *name, void *opaque, Error **errp)
+ const char *name, IOThreadParamInfo *info, Error **errp)
{
IOThread *iothread = IOTHREAD(obj);
- IOThreadParamInfo *info = opaque;
int64_t *field = (void *)iothread + info->offset;
visit_type_int64(v, name, field, errp);
}
static bool iothread_set_param(Object *obj, Visitor *v,
- const char *name, void *opaque, Error **errp)
+ const char *name, IOThreadParamInfo *info, Error **errp)
{
IOThread *iothread = IOTHREAD(obj);
- IOThreadParamInfo *info = opaque;
int64_t *field = (void *)iothread + info->offset;
int64_t value;
@@ -266,16 +264,18 @@ static bool iothread_set_param(Object *obj, Visitor *v,
static void iothread_get_poll_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
+ IOThreadParamInfo *info = opaque;
- iothread_get_param(obj, v, name, opaque, errp);
+ iothread_get_param(obj, v, name, info, errp);
}
static void iothread_set_poll_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
IOThread *iothread = IOTHREAD(obj);
+ IOThreadParamInfo *info = opaque;
- if (!iothread_set_param(obj, v, name, opaque, errp)) {
+ if (!iothread_set_param(obj, v, name, info, errp)) {
return;
}
@@ -291,16 +291,18 @@ static void iothread_set_poll_param(Object *obj, Visitor *v,
static void iothread_get_aio_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
+ IOThreadParamInfo *info = opaque;
- iothread_get_param(obj, v, name, opaque, errp);
+ iothread_get_param(obj, v, name, info, errp);
}
static void iothread_set_aio_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
IOThread *iothread = IOTHREAD(obj);
+ IOThreadParamInfo *info = opaque;
- if (!iothread_set_param(obj, v, name, opaque, errp)) {
+ if (!iothread_set_param(obj, v, name, info, errp)) {
return;
}