diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2024-03-25 10:41:00 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2024-03-25 10:41:00 +0000 |
| commit | e921e00d4ba6840063d69cb637331d0dc4905e4b (patch) | |
| tree | 490d623c664a6904b0066877cc2ba51bff4ee6a7 /tests | |
| parent | 80e9791a93b856ae959cf0efa04cee53390ed000 (diff) | |
tests/unit/socket-helpers: Don't close(-1)
In socket_check_afunix_support() we call socket(PF_UNIX, SOCK_STREAM, 0)
to see if it works, but we call close() on the result whether it
worked or not. Only close the fd if the socket() call succeeded.
Spotted by Coverity.
Resolves: Coverity CID 1497481
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20240312183810.557768-3-peter.maydell@linaro.org
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/socket-helpers.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tests/unit/socket-helpers.c b/tests/unit/socket-helpers.c index 6de27baee2..f3439cc4e5 100644 --- a/tests/unit/socket-helpers.c +++ b/tests/unit/socket-helpers.c @@ -160,7 +160,6 @@ void socket_check_afunix_support(bool *has_afunix) int fd; fd = socket(PF_UNIX, SOCK_STREAM, 0); - close(fd); #ifdef _WIN32 *has_afunix = (fd != (int)INVALID_SOCKET); @@ -168,5 +167,8 @@ void socket_check_afunix_support(bool *has_afunix) *has_afunix = (fd >= 0); #endif + if (*has_afunix) { + close(fd); + } return; } |