diff options
| author | Viresh Kumar <viresh.kumar@linaro.org> | 2014-05-09 11:01:19 +0530 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2014-09-05 09:52:50 +0530 |
| commit | 862a178f89c792765d33e12a068af2e4de23858a (patch) | |
| tree | c3d5c5e62cd169ecc42b00aa515c4f62062c1a02 | |
| parent | 0218350160c4d4470de4e6fc5ee9e84eb1bc09ae (diff) | |
hrtimer: reprogram event for expires=KTIME_MAX in hrtimer_force_reprogram()
In hrtimer_force_reprogram(), we are reprogramming event device only if the next
timer event is before KTIME_MAX. But what if it is equal to KTIME_MAX? As we
aren't reprogramming it again, it will be set to the last value it was, probably
tick interval, i.e. few milliseconds.
And we will get a interrupt due to that, wouldn't have any hrtimers to service
and return without doing much. But the implementation of event device's driver
may make it more stupid. For example: drivers/clocksource/arm_arch_timer.c
disables the event device only on SHUTDOWN/UNUSED requests in set-mode.
Otherwise, it will keep giving interrupts at tick interval even if
hrtimer_interrupt() didn't reprogram tick..
To get this fixed, lets reprogram event device even for KTIME_MAX, so that the
timer is scheduled for long enough.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
| -rw-r--r-- | kernel/hrtimer.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 1ebb7a1b2809..f8f466a09992 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -569,8 +569,7 @@ hrtimer_force_reprogram(struct hrtimer_cpu_base *cpu_base, int skip_equal) cpu_base->expires_next.tv64 = expires_next.tv64; - if (cpu_base->expires_next.tv64 != KTIME_MAX) - tick_program_event(cpu_base->expires_next, 1); + tick_program_event(cpu_base->expires_next, 1); } /* |