summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Kuvyrkov <maxim.kuvyrkov@linaro.org>2020-05-27 13:52:19 +0000
committerMaxim Kuvyrkov <maxim.kuvyrkov@linaro.org>2020-05-27 15:26:49 +0000
commitccb12e1c5c404822b067fed6892858e646c72161 (patch)
tree65a1cbe7c46c8e98e3c9e6182ccc6b1b0972b8d6
parent606fe7b4f7dbe40d7a50d37bdb00fa4a2b850210 (diff)
tcwg_bmk-build.sh: Adjust build scores
Don't bisect benchmark build/run failures in *-vs-* configurations. These failures will also appear in non-vs configurations, and will be bisected more efficiently. Change-Id: Iad4a70a9b13e5509ff95e8dabde942a55f5c10b9
-rwxr-xr-xtcwg_bmk-build.sh9
1 files changed, 7 insertions, 2 deletions
diff --git a/tcwg_bmk-build.sh b/tcwg_bmk-build.sh
index f750893a..7129c529 100755
--- a/tcwg_bmk-build.sh
+++ b/tcwg_bmk-build.sh
@@ -519,13 +519,18 @@ case "${rr[toolchain]}" in
esac
case "${#cflags[@]}" in
2)
- run_step skip_on_fail 0 benchmark "${cflags[0]}" -- ${rr[top_artifacts]}/results_id-1
- run_step skip_on_fail 1 benchmark "${cflags[1]}" -- ${rr[top_artifacts]}/results_id-2
+ # Don't bisect benchmark build/run failures in *-vs-* configurations.
+ # Bisections happen only for regressions with build scores >=0,
+ # which will happen if benchmark "${cflags[1]}" succeeds.
+ run_step skip_on_fail -1 benchmark "${cflags[0]}" -- ${rr[top_artifacts]}/results_id-1
+ run_step skip_on_fail 0 benchmark "${cflags[1]}" -- ${rr[top_artifacts]}/results_id-2
# shellcheck disable=SC2154
rr[no_regression_p]=no_regression_vs_p
run_step reset_on_fail x check_regression
;;
1)
+ # Bisect benchmark build/run failures in non-vs configurations.
+ # Set score to "0" with "true".
run_step skip_on_fail 0 true
run_step skip_on_fail 1 benchmark "${cflags[0]}" -- ${rr[top_artifacts]}/results_id
rr[no_regression_p]=no_regression_to_base_p